The entity controller's view method doesn't call the same hooks that other entity view functions do, namely hook_entity_view_alter() and hook_TYPE_view_alter().
Also the view method returns a string instead of an array. template_preprocess_panels_pane, and theme_panels_naked_style_render_pane, theme_panels_block_style_render_pane all appear to support render arrays. If this method can return an array instead, it means I can add contextual links to fieldable_panels_pane entities using the same hooks I use to add them for all entities.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | delegate-render-1555414-2.patch | 572 bytes | helior |
| #1 | fieldable_panels_pane_view_alter-1555414-1.patch | 655 bytes | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) commentedComment #2
helior commentedIt looks like the alter hook was already added here: http://drupalcode.org/project/fieldable_panels_panes.git/blobdiff/063fbb...
However still, delegating the render of the content will allow hook_panels_pane_content_alter() to attach js/css to the render array, rather than calling drupal_add_*, which is absolutely vital if you're using panel caching.
I'm updating the patch to just skip rendering the content early.
Comment #3
twistor commentedLooks good.
Comment #4
merlinofchaos commentedThis seems reasonable. We should watch out because it is potentially possible but highly unlikely that someone is calling the view function assuming they'll get rendered content back. However our internal calls appear to all be okay with rendered or unrendered, so this is okay for us.
Committed and pushed.