Closed (fixed)
Project:
Corolla
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 May 2012 at 19:50 UTC
Updated:
17 May 2012 at 01:30 UTC
I was receiving the message that the following css files were missing: responsive.smartphone.landscape.css
responsive.smartphone.portrait.css
responsive.tablet.landscape.css
responsive.tablet.portrait.css
responsive.desktop.css
responsive.cascade.css
The documentation says that these files should be part of the subtheme`s css files which are currently not shipped with the dev. I took those files from the core subtheme's css folder and the message went away (unsurprisingly).
Side-note: The message was printed to anybody despite the settings under "error reporting" to print no messages to the screen. Does this theme currently disobey those settings?
Comments
Comment #1
Jeff Burnz commentedAh, missing file bug, yes I knew there was something I might have missed - the responsive styles need to be abstracted to these stylesheets, thats really the big task before we get to a release, shouldn't take that long and is probably the last real major task.
This system of warnings was put in place to ease migration management for really big sites, its kinda long winded to explain why, the original issue is here: #1543990: Set message if generated files are missing, document file generation
The theme is issuing warnings via
drupal_set_message(). The warnings could be hidden from non-admins, that's (possibly) doable, I need to check if I can get the global user in all the right scopes, mostly for these particular warnings pretty sure I can. If they are not being hidden as you say, it could be a bug with Drupal core, the theme is not doing anything outrageous with this, merely usingdrupal_set_message()as per normal.Comment #2
Jeff Burnz commentedOh great, I dont even need global user, I can use user_is_logged_in(), thats nice of the API.
Comment #3
Jeff Burnz commentedI've silenced the warnings for non-logged in users in the latest commit to AT Core.
Comment #4
Jeff Burnz commentedActually in the RC I just released I made the decision to remove the checks for these files. The reason is that many of the older themes simply don't need these files and to ease upgrade issues you can simply choose not to use them, in which case the theme should not check. There are other ways around this but at the end of the day I decided to just remove it for now, and revisit the whole issue in a few months time and see if we really need to the checks for these specific files or not.
In essence this is fixed by removing the checks.