How to test:
1) apply patch
2) produce a view with exposed /sort criteria/ fields. *this patch works with sorts only*
3) Choose Exposed form style "Sort form text links".
4) Navigate into exposed form "settings", and fill out labels as appropriate (put arbitrary stuff for testing) in "Exposed sort fields asc/desc labels" fieldset section. and apply the settings form.
5) run your view for test using "update preview" admin UI button or produce views block/page to see results.
5.1) You should see exposed form rendered as clickable links. If you dont, file bug report :)
6) $$$

Things to look out for (my mistakes :) ):
1) I do a lot of deep object access, such as $this->view->display['default']->display_options['sorts']. I suspect this is wrong, but i dont know for sure (not too familiar with low level API yet). Should i be accessing display_options['sorts'] using some kind of getting method?
2) I've mentioned this above, but i'll reiterate: This plugins works only with /sort/ fields. Other fields should not be exposed in this plugin until further developed (if ever). Do not report this as a bug.
3) ???

CommentFileSizeAuthor
#1 1556680-views-views_plugin_exposed_form_basic_links.patch5.94 KBlitwol

Comments

litwol’s picture

litwol commented
Status: Active » Needs review
StatusFileSize
new 1556680-views-views_plugin_exposed_form_basic_links.patch5.94 KB

And the patch :)

litwol’s picture

litwol commented

By the way, i have no particular hope/agenda to get this into views. First and foremost i am looking for sanity check and help me explore whether this has a potential.

I'll gladly put in further work to bring this to some kind of completion... what ever that may turn out to be after sanity check/review.

chris matthews’s picture

chris matthews commented
Assigned: litwol » Unassigned
Issue summary: View changes

The 7 year old patch applied cleanly to the latest views 7.x-3.x-dev and if still applicable needs review.

Checking patch includes/plugins.inc...
Hunk #1 succeeded at 311 (offset 3 lines).
Checking patch plugins/views_plugin_exposed_form_basic_links.inc...
1556680-views-views_plugin_exposed_form_basic_links.patch:133: new blank line at EOF.
+
Checking patch views.info...
Hunk #1 succeeded at 236 (offset 14 lines).
Applied patch includes/plugins.inc cleanly.
Applied patch plugins/views_plugin_exposed_form_basic_links.inc cleanly.
Applied patch views.info cleanly.
warning: 1 line adds whitespace errors.