Posted by gordon on May 2, 2012 at 4:23am
4 followers
| Project: | Mollom |
| Version: | 7.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
When watchdog() is being called now the text is being expanded, so instead of using
Spam: @message
it is using
Spam:
This is causing issues with the mongodb watchdog because it groups all the watchdog entries together by the raw message which generally means that there is only 1 watchdog entry for Spam, Ham, and Unsure instead now with this change the majority of my main watchdog listing page is taken up with spam messages.
Comments
#1
I found that in the merging of the watchdog messages it was preprocessing the messages, removing the arguments and making the messages being posted as a single text string.
Ordinarily this would not be a problem, but using 3rd party watchdog tools like mongodb_watchdog which consolidates the log messages based upon the raw message (i.e. the message with the place holders still in tack "spam: %teaser") which makes it harder to manage the messages.
Also the side effect of this with mongodb because it creates a new collection for every new message text which will have ultimately 1 or 2 messages in it, was requiring that mongodb consumed a hugh amount of space.
I have made a change so that when it merges all the watchdog messages it will now merge both the message and the arguments. With the arguments I have put in some conflict detection and arguments will be renamed if there is going to be a conflict.
#2
The last submitted patch, mollom-1556682.patch, failed testing.
#3
We've introduced the new formatted log messages in #1000690: Revamp and reduce log messages (was: Not clear that fail-over is working)
The current log messages are always different, because we are grouping multiple requests to Mollom into a single message, but still want to see the full history. Thus, I'm not sure how this could use any kind of always identical placeholders to make Mongo happy...?
#4
Actually the patch that I have submitted, it gives the consolidated messages, but retains all the arguments so that mongodb can still consolidate, and I don't get a run away in space.
I need to take a look at the patch and see why it failed.
#5
We got bitten by this as well mollom create about 21k collections since we rolled new version and are in process of applying this patch to production. There is a bug in the patch $new_arg is not defined I think you meant to use $new_key there attaching fixed up patch.
#6
#7
The last submitted patch, mollom-1556682-2.patch, failed testing.
#8
#9
#5: mollom-1556682-2.patch queued for re-testing.
#10
Bumping this to critical no way to say how many sites out there use MongoDB and Mollom but for those they do this bug can crash their servers.