Just starting to poke through these, and the first thing that jumps out at me is when seeing:

$session->visit('http://drupal.org/sandbox/eliza411/1545884/');

that we really need to be able to make the base url that's in use configurable. actually, it's not just that - we need to be able to specify a set of base urls (e.g. git6{,site,viewer}.devdrupal.org). Seems like something we should be able to do with some simple dependency injection.

i'm sure y'all discussed this elsewhere, but i'm noting it here as i don't see an issue :)

Comments

eliza411’s picture

eliza411 commented
Status: Active » Needs review

Took a first pass at abstracting this in the eliza411 topic branch, commit 5661e2e1.

Base url is set in the behat.yml file:
context:
parameters:
base_url: 'http://drupal.org/'

It doesn't help with sets of base URLs, but I don't really understand the use case well enough to try working on that requirement.

eliza411’s picture

eliza411 commented
Assigned: Unassigned » sdboyer
Status: Needs review » Needs work

The base_url been abstracted in the behat.local.yml file, but nothing addresses the sets of URLs because don't think anyone who's following this project knows what to do.

sdboyer’s picture

sdboyer commented
Status: Needs work » Fixed

hmmm...well, we might be able to get away with just having the base url of the main site instance, as the other urls should be able to be read as needed from the main site itself. the other parts of the set being git interaction URLs and the git viewer.

so really, this is more the problem with project_git_instructions not being able to handle the more verbose ssh:// syntax for git interaction that's required when using a nonstandard ssh port.

in any case, marking fixed, as we've gotten the essential problem taken care of.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.