I'm unclear about what this is.

Notice: Undefined index: HTTP_USER_AGENT in _record_user_agent() (line 33 of /var/www/sites/all/modules/browscap/record.inc).

This is probably an easy question to answer, unfortunately this is new to me and makes no sense yet.

CommentFileSizeAuthor
#5 add-check-to-prevent-errors-1557756-5.patch2.25 KBdevin carlson
#3 add-check-to-prevent-errors-1557756-3.patch1.83 KBdevin carlson
#1 browscap_1557756.patch619 bytestobiasb

Comments

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Version: 7.x-1.3 » 7.x-1.x-dev
Category: support » bug
Status: Active » Needs review
StatusFileSize
new browscap_1557756.patch619 bytes

this error comes most, when a bot visit the website. the attached patch is for 6.x and 7.x.

kurtismccartney’s picture

kurtismccartney commented
Status: Needs review » Reviewed & tested by the community

Works for me. Thanks tobiasb.

devin carlson’s picture

devin carlson commented
Component: Miscellaneous » Code
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new add-check-to-prevent-errors-1557756-3.patch1.83 KB

Thanks for the patch and feedback!

The attached patch implements the same check as the patch in #1 but also includes some minor cleanup.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Committed to 7.x-1.x.

devin carlson’s picture

devin carlson commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Needs review
StatusFileSize
new add-check-to-prevent-errors-1557756-5.patch2.25 KB

Backport of #4.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Committed to 6.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

promes’s picture

promes
Primary language Dutch
commented
Version: 6.x-1.x-dev » 7.x-1.3
Status: Closed (fixed) » Active

I tried to apply patch #5 in D7 but this patch couldn't be applied (D6 db_query code?).
So I applied patch #3.

Is a patch #5 available for D7 or a 7.x-1.x-dev file with a correct patch?

Thanks.

devin carlson’s picture

devin carlson commented
Status: Active » Closed (works as designed)

User agent recording is no longer part of Browscap.