Active
Project:
Speedy
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 May 2012 at 12:48 UTC
Updated:
20 Mar 2013 at 19:07 UTC
Seems like, out of the box, only Drupal up to v. 7.9 is supported. What about the newer versions?
Comments
Comment #1
johnalbinThe latest -dev shows it has up to Drupal 7.12 now. But is lacking 7.13 and 7.14 that came out this week.
Comment #2
johnalbinYou will constantly be chasing Drupal core releases. And as a site admin, I'll have to wait until this module is updated before updating core, even if it is a security release.
Couldn't the code assume to use either a matching version (what the code currently does) or, if no match, the latest version of the minified files?
I'm currently running "7.15-dev" on my dev site, so the minified versions aren't loaded.
Comment #3
mfer commentedFirst, I've updated through 7.14. If you want to generate your own you can use drush with the command `drush smj /path/to/uglifyjs` and it will generate the minified js files.
Are you proposing that we switch to using the latest if the version is unknown? Otherwise use the version if we have it?
Comment #4
dddave commentedThe current core update comes with a update which won't run with speedy enabled. A little word of caution on the module page and perhaps in the config of this module would be nice.
Comment #5
johnalbin@dddave: It doesn't sound like your issue is related to this discussion. Please open a new issue; also please provide more detail then there's an "update which won't run" which is much too vague.
Comment #6
dddave commentedSorry, opened: #1710354: Speedy blocks update of system module shipped with 7.15
Comment #7
klonosInstead of chasing core stable and dev versions as they are released every now and then, how about we create a 7.x-2.x branch of the module that works as following:
- Index all core .js files and store a checksum/filename pair for each one in the database.
- Minify all these files under /sites/all/files/speedy/ (instead of shipping the module with minified versions for each core version)
- With each cron run, fire a job that re-indexes all .js files (also looking for new ones added) and compares current checksums with the old ones from the previous run.
- For files that have changed checksums, minify them and overwrite old minified versions of them under /sites/all/files/speedy/
...magic!!!
Des this make sense? Is it doable?
Comment #8
klonos...looking at the issues in this module's queue, I see that something very similar to my proposal was already suggested in #1525424-4: Make minification dependent on file modification date