At the 'Configure facet display' page I have no way of knowing which facet I am working with, short of peering at the URL (such as admin/config/search/facetapi/apachesolr%40solr/block/ss_brand/edit) and trying to figure it out from that.

CommentFileSizeAuthor
#4 admin-page-titles-1557784-4.patch1.97 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented

Makes sense to me. Would love to see a patch to resolve the issue.

Thanks for reporting,
Chris

joachim’s picture

joachim commented

I'm completely new to this module, so not sure where to best put this info or indeed how much there is to convey:

- in the page title or in the form as text?
- how much of the pieces of 'apachesolr%40solr/block/ss_brand' need to be given and how can they be converted to human strings?

cpliakas’s picture

cpliakas commented

After taking a quick look through the code, the facetapi_facet_display_form() function is where this should be attacked. You can see where the "drupal_set_title()" is executed, and you could also add a header if you want as well. I will leave it up to you, and would love to see a patch for this.

Thanks,
Chris

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new admin-page-titles-1557784-4.patch1.97 KB

Attached patch makes the suggested change.

Status: Needs review » Needs work

The last submitted patch, admin-page-titles-1557784-4.patch, failed testing.

cpliakas’s picture

cpliakas commented
Version: 7.x-1.0-rc4 » 7.x-1.x-dev
Status: Needs work » Needs review

Let's try testing against the correct branch...

cpliakas’s picture

cpliakas commented

#4: admin-page-titles-1557784-4.patch queued for re-testing.

cpliakas’s picture

cpliakas commented

Bump to first page.

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Committed to all branches of Facet API:

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.