Closed (fixed)
Project:
Ubercart
Version:
6.x-2.9
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 May 2012 at 00:18 UTC
Updated:
26 May 2012 at 11:40 UTC
While all the queries apparently execute OK, update.php throws two warnings during the update:
warning: array_merge() [function.array-merge]: Argument #2 is not an array in /Applications/MAMP/htdocs/update.php on line 173.
warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/update.php on line 337.
Are these harmless warnings, or indications of a deeper problem?
The following queries were executed
uc_payment module
Update #6003
ALTER TABLE {uc_payment_receipts} CHANGE `comment` `comment` TEXT DEFAULT NULL
uc_ups module
Update #6201
No queries
uc_cart module
Update #6203
ALTER TABLE {uc_cart_products} CHANGE `qty` `qty` INT unsigned NOT NULL DEFAULT 0
uc_order module
Update #6020
ALTER TABLE {uc_order_products} CHANGE `qty` `qty` INT unsigned NOT NULL DEFAULT 0
Update #6200
Deleted unwanted sensitive data.
uc_store module
Update #6007
ALTER TABLE {uc_countries} ADD `weight` TINYINT NOT NULL DEFAULT 0
Comments
Comment #1
tr commentedWhy do you think the PHP warnings came from Ubercart? A quick search shows thousands of reports of this warning during update that are totally unrelated to Ubercart, so it seems more like a general Drupal issue. Even if this is something caused by Ubercart, there are so many site-specific things that could go wrong that unless this can be reproduced on an upgrade of a clean install, I don't see a way of easily tracking this down without some indication of which update function was being run at the time.
As for the second part of your question, those aren't "warnings", they're informational messages telling you what changes were made in the update process. That's a normal part of Drupal.
Comment #2
MakeOnlineShop commentedSo the new update is okay finally ?
Comment #3
jantoine commentedThis issue comes from the uc_ups_update_6201() function as it is not returning an array as specified in the documentation for hook_update_N().
Comment #4
tr commented@AntoineSolutions: You're correct - that update function was a D7-style update function. That seems to be the only one in the 6.x-2.x distribution. I've pushed a fix.
Thanks for finding this!
Comment #5
sander-martijn commentedwhen you say you've pushed a fix, should i use the dev version or reinstall 6.x-2.9, or is it not an error I need to worry about?
Comment #6
longwaveThe warnings are harmless, you can safely ignore them.