Posted by bangpound on May 3, 2012 at 6:18am
5 followers
| Project: | Chaos tool suite (ctools) |
| Version: | 7.x-1.x-dev |
| Component: | Page Manager |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Function in term_view.inc page_manager_term_view_page() only gets the term and not the depth, even though the task's arguments include a depth.
Comments
#1
I rolled this against 7.x-1.0 for expedience.
#2
I was reviewing CTool code and checked out your issue, but have a question. I tracked the use of the function ctools_context_handler_get_task_contexts and could not find a circumstance where it requires the $depth variable. Which $task are you referring to and/or why is depth required? Also what is the result of having the argument missing?
#3
ctools_context_handler_get_task_contexts() is a function that is called by all task handlers that use context not just terms. As such, it doesn't expect a depth but rather an array of all contexts. The task I'm talking about is the one I patched: term_view.inc.
#4
The problem is that the depth was eliminated from taxonomy/term/%term in D7.
#5
If you enable the task handler for term_view, enable the taxonomy_term view that is included with Views, and apply the patch, you can get all that back.
taxonomy/term/[tid]/[depth] works
taxonomy/term/[tid],[tid],[tid]/[depth] works too.
Views can accept a depth argument, but the CTools term handler never passes the depth argument even though the taxonomy term context argument sets it up.
#6
Hi, It would be great to have the term-depth back into ctools. I am allready over a year searching for a good way to handle different ctools-panels based on the term depth.
Sorry if this comment is out of topic. But I think taxonomy depth is a valuable mechanism!
Greetings, Martijn
#7
I agree it's valuable, I was just concerned about the implications. But I'd rather have the feature available. I don't think it'll break anything.
#8
Committed and pushed.
#9
Automatically closed -- issue fixed for 2 weeks with no activity.