Closed (duplicate)
Project:
Webform
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Jul 2007 at 01:51 UTC
Updated:
17 Jul 2007 at 11:11 UTC
I'm not sure of the expected behaviour of
if (strcmp('none', $node->email_from_name)) {
$email_from_name = '';
}
Don't you just want to check if $node->email_from_name is 'none'?
strcmp returns 0 when the values are the same, as opposed to the expected 1.
This patch corrects that. (+ minor typo in the first comment of the file).
Also, are you sure that having the choice of from = none is a good idea? Not sure that all the email server will accept that (processing, spam).
'Default' should be enough and ensure that these fields are not empty.
| Comment | File | Size | Author |
|---|---|---|---|
| webform.from_none.patch | 1.17 KB | scor |
Comments
Comment #1
scor commentedDuplicate http://drupal.org/node/152165