Closed (fixed)
Project:
Views RSS: Media (MRSS) Elements
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
3 May 2012 at 12:41 UTC
Updated:
19 Dec 2012 at 23:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
davidseth commentedComment #2
maciej.zgadzaj commentedEh, this one is much more tricky. Essentially these preprocess functions do not work properly now as they were written for the old way of building the feed by Views RSS module. Now that is uses format_xml_elements() all preprocess functions need to be rewritten. And then:
- removing preprocess for
<media:thumbnail>is fine,- preprocess for
<media:content>cannot really be removed, as then we're loosing optional<media:group>element - it needs to be refactored instead,- all other current preprocess functions need to be refactored as well (excluding
views_rss_htmlspecialcharswhich just needs to be removed),- I need a good solution for
<media:category>element - formatter would be the best here, but as taxonomy fields in Views do not use formatters, I would need something similar toviews_rss_handler_field_term_node_tidclass from Views RSS module (actually almost identical), but then don't like the idea of extending that class again... need to think it through.Comment #3
davidseth commentedThanks for the update... I will keep an eye on this.
Comment #4
davidseth commentedJust a quick check in to see if you had any more thoughts on the matter.
Regards,
David
Comment #5
Chris CharltonChecking in on this. Any more code thoughts to review or are we just missing a good set of patches at this point?
Comment #6
maciej.zgadzaj commentedI've started working on this quite a some time ago, but then had other work coming and didn't have time to finish it yet I'm afraid. Should get back to it soon though.
Comment #7
Chris CharltonIs there anything I can help with to move this along?
I am assigned to a project currently where this module is quite critical. LMK
Comment #8
maciej.zgadzaj commentedYou might want to check
7.x-1.x-temporary-codebranch - allmedia:elements should be working now, apart frommedia:category, which for the moment is disabled. I will re-enable it once I have an idea how to make it work in a nice way.Please note that this is code in progress, only very roughly tested, hence not yet committed to main dev branch. Would be cool though if someone played with it a bit too and shared the effects.
Comment #9
maciej.zgadzaj commentedFYI - branch
7.x-1.x-temporary-codehas been deleted, all updates have been merged into7.x-1.xbranch,<media:category>element has been re-enabled, all fields should work fine now. Please read freshly added Setting up Media feed elements documentation for more info.