First of all: Absolutely awesome module! This is just what I have been waiting for (without even knowing). No need for using complicated revisions anymore for relatively simple tasks. Support for user profiles (profile2) would make it perfect. This is a great start though!

The module is working just as expected. However I am getting the following warnings when updating a node. It seems that the warning is being repeated just as many times on the screen as there are field being watched by the module:

Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_after->render() (Zeile 38 von E:\xampp\htdocs\test\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_after.inc).

Not sure if this is caused by the module at all. The functionality doesn't seem to be affected. Just wanted to check whether something can be done about this?

Thanks in advance.

CommentFileSizeAuthor
#11 track_field_changes-strict-fixes-1559736-11.patch1.61 KBisilweo
#6 view.txt18.47 KBGolem07

Comments

targoo’s picture

targoo commented

thanks for reporting this. I will look into it asap.

targoo’s picture

targoo commented

can you still see these messages in the latest release ?

Golem07’s picture

Golem07 commented

After a few tests with the latest release (beta 4) I did not see the notices any more so I guess they are gone for good!. Thank you.

Golem07’s picture

Golem07 commented

... and it is back (beta4). Even though the following notices are different and only show when accessing a view displaying changes and not when updating a node. Futhermore the notices do not appear on the view preview but only on the saved page view:

•	Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_before->render() (Zeile 38 von E:\xampp\htdocs\test\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_before.inc).
•	Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_after->render() (Zeile 38 von E:\xampp\htdocs\test\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_after.inc).
•	Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_before->render() (Zeile 38 von E:\xampp\htdocs\test\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_before.inc).
•	Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_after->render() (Zeile 38 von E:\xampp\htdocs\test\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_after.inc).
•	Notice: Undefined index: value in _text_sanitize() (Zeile 319 von E:\xampp\htdocs\test\modules\field\modules\text\text.module).
•	Notice: Undefined index: format in _text_sanitize() (Zeile 319 von E:\xampp\htdocs\test\modules\field\modules\text\text.module).
•	Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_before->render() (Zeile 38 von E:\xampp\htdocs\test\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_before.inc).
•	Notice: Undefined index: value in _text_sanitize() (Zeile 319 von E:\xampp\htdocs\test\modules\field\modules\text\text.module).
•	Notice: Undefined index: format in _text_sanitize() (Zeile 319 von E:\xampp\htdocs\test\modules\field\modules\text\text.module).
•	Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_after->render() (Zeile 38 von E:\xampp\htdocs\test\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_after.inc).
targoo’s picture

targoo commented

do you use any custom field ?

can you export your view ?

Golem07’s picture

Golem07 commented
StatusFileSize
new view.txt18.47 KB

Hi,

thanks for the quick reply:

I used only the node title and one text field in the view. Here it is:

targoo’s picture

targoo commented

I can't reproduce it. Could you send me your DB on my personal email address (targoo@gmail.com) ?

targoo’s picture

targoo commented
Status: Active » Closed (cannot reproduce)

can't reproduce

Ionut Adrian Luchian’s picture

Ionut Adrian Luchian commented
Version: 7.x-1.0-beta1 » 7.x-1.0
Status: Closed (cannot reproduce) » Active

I have this error, me too.

Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_before->render() (line 38 of C:\Users\Ionut Adrian Luchian\Sites\dalex\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_before.inc).
Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_after->render() (line 38 of C:\Users\Ionut Adrian Luchian\Sites\dalex\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_after.inc).

After updating a field value, in my view (Grid format) appears 2 rows like in this image: click to see the image
Thank you.

PS. I selected version 7.x-1.1

tree887’s picture

tree887 commented

Hi,

Was anyone able to find a solution to the errors, by chance?
This is such a useful module by the way! Thank you!!!

Strict warning: Only variables should be passed by reference in track_field_changes_handler_field_value_after->render() (line 38 of C:\Users\Chris\Sites\acquia-drupal\sites\all\modules\track_field_changes\views\track_field_changes_handler_field_value_after.inc).

isilweo’s picture

isilweo commented
Issue summary: View changes
StatusFileSize
new track_field_changes-strict-fixes-1559736-11.patch1.61 KB

Those notices are coming from PHP 5.4. They're easly fixable. See attached patch for fix.

Dandily’s picture

Dandily commented

isilweo, thank you, it's works for me.

cockers’s picture

cockers commented

Thank you isilweo, the patch has worked for me too. Can we commit it?

MattWithoos’s picture

MattWithoos commented
Status: Active » Closed (fixed)

This has been committed into 7.x-1.4

https://www.drupal.org/node/2488366