The form builder code for retaining filters seems to be totally broken. The code seems to be looking for a run search where non can exist, so the form element is excluded and the form value is thus missing in the submit function.

CommentFileSizeAuthor
#4 1559880-4-D6.patch3.03 KBnick_vh
#3 1559880-3-D6.patch2.42 KBpwolanin
#1 1559880-1.patch2.45 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 1559880-1.patch2.45 KB
pwolanin’s picture

pwolanin commented
Title: 'retain filters' checkbox does work. » 'retain filters' checkbox does not work.
pwolanin’s picture

pwolanin commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
StatusFileSize
new 1559880-3-D6.patch2.42 KB

committed to 7.x, needs 6.x-3.x testing ($form_state is different)

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1559880-4-D6.patch3.03 KB

Needed a small modification

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Fixed

Committed, thanks for the work!

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Fixed » Closed (fixed)