I've been trying to create my own version for this, been running into issues with the page cache when turned on when setting the cookie.

How did you get round this issue?

Comments

Miszel’s picture

Miszel commented

It's difficult to say what problems you are experiencing without seeing your code. Are you setting your cookies using PHP or JavaScript? If you do that with PHP, it won't work with drupal page cache or Varnish because your logic will be bypassed.

david.riches’s picture

david.riches commented

Yeah i was setting it with php.. then came across page caching.
Yours i see seems to set it in the javascript. I have page caching turned on. the dropdown doesn't always appear on all pages. (before cookie is set.)

Have you experienced this?

Miszel’s picture

Miszel commented

I am not sure what dropdown you are referring to...?

It seems to be working ok. I haven't experienced any problems. You can try the 6.x-1.x branch.

david.riches’s picture

david.riches commented

Your version. Apologies

Right i think i have this working with page cache now. seems a bit jumpy the drop-down from the top after i select 'Yes i agree'. (i have to refresh the page to get the thankyou message.)

have you experienced this? I noticed on your demo you have it set to the bottom.

Cheers

Miszel’s picture

Miszel commented

yes, I replicated the problem. I will fix it. Thanks for reporting.

david.riches’s picture

david.riches commented

No worries.
Thanks for a creating a module on this!

Miszel’s picture

Miszel commented
Title: Drupal 6 caching turned on 'normal'. » pop up when placed at the top, is not working correctly
Assigned: Unassigned » Miszel
Category: support » bug
Miszel’s picture

Miszel commented
Status: Fixed » Active

Fixed in 6.x-1.1

Miszel’s picture

Miszel commented
Status: Active » Fixed
Miszel’s picture

Miszel commented
Status: Active » Closed (fixed)