Closed (fixed)
Project:
Aggregation
Version:
5.x-3.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
2 Jul 2007 at 07:41 UTC
Updated:
3 Jul 2007 at 07:48 UTC
Jump to comment: Most recent file
I found that piece of code in RDF10.inc:
if ($name = 'about')
I cannot see any reason in the surrounding code that this assignment has a reason.
I assume this is an unfortunate typo.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | RDF10.inc__0.txt | 2.64 KB | vito_swat |
Comments
Comment #1
vito_swat commentedTrere is reason for this.
As RDF spec says:
According to spec metioned above I used rdf:about as identifier (guid). The whole pice of code is:
which looks for any attributes of item tag and if this attribute is about than get it as guid. The outer foreach (not included in piece above) takes care of namespaces. You cannot assume that any other namespace is not defining any attributes for item tag so you have to check its name.
If you need more details about this handler feel free to contact me by contact form.
Comment #2
vito_swat commentedComment #3
vito_swat commentedOf course this is typo. I look at this so mamy times I didn't notice... You're right. There should be == instead of =.
Comment #4
vito_swat commentedI corrected this typo and carefully chcecked code one more time.
Mistknight please commit this handler.
Comment #5
Ashraf Amayreh commentedI've missed that as well, thanks Aaron.
Fixed on *hopefully* soon to come next release.
Comment #6
Ashraf Amayreh commentedThanks vito, committed :)