I found that piece of code in RDF10.inc:

if ($name = 'about')

I cannot see any reason in the surrounding code that this assignment has a reason.
I assume this is an unfortunate typo.

CommentFileSizeAuthor
#4 RDF10.inc__0.txt2.64 KBvito_swat

Comments

vito_swat’s picture

Trere is reason for this.
As RDF spec says:

Required Attribute(s): rdf:about
[...]
{item_uri} must be unique with respect to any other rdf:about attributes in the RSS document and is a URI which identifies the item. {item_uri} should be identical to the value of the
sub-element of the element, if possible.

According to spec metioned above I used rdf:about as identifier (guid). The whole pice of code is:

//get about attribute as guid
foreach ($news->attributes($ns_link) as $name => $value)
	if ($name = 'about')
		$guid = $value; 

which looks for any attributes of item tag and if this attribute is about than get it as guid. The outer foreach (not included in piece above) takes care of namespaces. You cannot assume that any other namespace is not defining any attributes for item tag so you have to check its name.

If you need more details about this handler feel free to contact me by contact form.

vito_swat’s picture

Assigned: Unassigned » vito_swat
vito_swat’s picture

Of course this is typo. I look at this so mamy times I didn't notice... You're right. There should be == instead of =.

vito_swat’s picture

Status: Active » Reviewed & tested by the community
StatusFileSize
new2.64 KB

I corrected this typo and carefully chcecked code one more time.
Mistknight please commit this handler.

Ashraf Amayreh’s picture

Status: Reviewed & tested by the community » Fixed

I've missed that as well, thanks Aaron.

Fixed on *hopefully* soon to come next release.

Ashraf Amayreh’s picture

Status: Fixed » Closed (fixed)

Thanks vito, committed :)