PHP contains a bug where for certain user-space stream wrappers the constructor is not called: https://bugs.php.net/bug.php?id=40459 .

It will probably take a while before this bug is fixed and a new PHP version is released. My suggestion is to add code to the Amazon S3 stream wrapper to invoke the constructor if it hasn't been called.

The reason I hit on this bug was that file_exists('s3://file') calls AmazonS3StreamWrapper::url_open(). Because the constructor isn't called, $this->cache is false, so these file_exists() calls always call S3, even when the file has been cached.

CommentFileSizeAuthor
#10 amazons3-constructorbug-1561176-10.patch3.63 KBJorrit
#1 amazons3-constructorbug-1561176-1.patch3.66 KBJorrit

Comments

Jorrit’s picture

Jorrit commented
Status: Active » Needs review
StatusFileSize
new amazons3-constructorbug-1561176-1.patch3.66 KB

Please see attached patch.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented

I've submitted a patch for this to PHP https://github.com/php/php-src/pull/93

Jorrit’s picture

Jorrit commented

I wouldn't bet on getting it committed quickly: http://markmail.org/message/zhj7h34x2xzk6an5

klakegg’s picture

klakegg commented

Looks like a fix is in, but it doesn't help today. Could we have it work correct now, and have the perfect code later?
https://github.com/php/php-src/pull/153

Jorrit’s picture

Jorrit commented

By the way: my patch works regardless of the fix in PHP.

klakegg’s picture

klakegg commented
Status: Needs review » Reviewed & tested by the community

This bug is a showstopper.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Status: Reviewed & tested by the community » Needs work

Patch needs rerolling

Jorrit’s picture

Jorrit commented
Status: Needs work » Needs review

Here you go.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Status: Needs review » Needs work

@Jorrit please attach a patch

Jorrit’s picture

Jorrit commented
Status: Needs work » Needs review
StatusFileSize
new amazons3-constructorbug-1561176-10.patch3.63 KB

Weird, I was sure it was there.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Status: Needs review » Fixed

Thanks, committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Jorrit’s picture

Jorrit commented

By the way: this patch is not necessary anymore from PHP 5.4.7 and up, see http://www.php.net/ChangeLog-5.php#5.4.7 .