the masquerade settings field that gets added to the user profile form does not have any weight assigned to it.

as soon as a user adds additional fields; since the masquerade field does not show on the manage fields form, it can't be moved relative to the new fields and ends up showing up in the middle of these new fields:

http://screencast.com/t/janRHvjvqj7

attached patch simply assigns that field a weight of 10 to move it down with the other admin fields

CommentFileSizeAuthor
#7 1561352-masquerade-field-7.patch922 bytesandypost
#2 field-extra-1561352-2.patch855 bytesmokaspar
masquerade-add_weight.patch507 bytesliquidcms

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work

To properly implement this functionality we need hook_field_extra_fields()

mokaspar’s picture

mokaspar commented
Title: masquerade field on user edit form should have weight » Add field ui support for user form and user display
Category: bug » feature
Status: Needs work » Needs review
StatusFileSize
new field-extra-1561352-2.patch855 bytes

Here's a patch using hook_field_extra_fields().

andypost’s picture

andypost
he/him
Primary language Russian
commented

Great, +1 to be commited. let's get more reviews

Angry Dan’s picture

Angry Dan commented
Status: Needs review » Reviewed & tested by the community

This patch is working nicely for me, fixing issues with not seeing the link when using Display Suite.

I think, after all this time, it's probably safe to commit!

My only comment, I usually consider it a good practice to instantiate variables:

$return = array();
$return['user']['user']  = array(
  ...
);

Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, field-extra-1561352-2.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 7.x-1.x-dev » 8.x-2.x-dev
Status: Needs work » Patch (to be ported)

commited 8ee534e

Suppose this could be backported to 8x. probably to "advanced module"

andypost’s picture

andypost
he/him
Primary language Russian
commented
Category: feature » task
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1561352-masquerade-field-7.patch922 bytes

pushed ea7dae9
still waits for advanced module

Status: Needs review » Needs work

The last submitted patch, 1561352-masquerade-field-7.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Fixed

pushed to 8.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit ea7dae9 on 8.x-2.x by andypost: 
    Issue #1561352 by andypost, mokaspar, liquidcms: Add field ui support...