Posted by liquidcms on May 4, 2012 at 3:35pm
5 followers
| Project: | Masquerade |
| Version: | 8.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
the masquerade settings field that gets added to the user profile form does not have any weight assigned to it.
as soon as a user adds additional fields; since the masquerade field does not show on the manage fields form, it can't be moved relative to the new fields and ends up showing up in the middle of these new fields:
http://screencast.com/t/janRHvjvqj7
attached patch simply assigns that field a weight of 10 to move it down with the other admin fields
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| masquerade-add_weight.patch | 507 bytes | Idle | FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch masquerade-add_weight.patch. Unable to apply patch. See the log in the details link for more information. | View details | Re-test |
Comments
#1
To properly implement this functionality we need hook_field_extra_fields()
#2
Here's a patch using hook_field_extra_fields().
#3
Great, +1 to be commited. let's get more reviews
#4
This patch is working nicely for me, fixing issues with not seeing the link when using Display Suite.
I think, after all this time, it's probably safe to commit!
My only comment, I usually consider it a good practice to instantiate variables:
<?php$return = array();
$return['user']['user'] = array(
...
);
?>
Thanks!
#5
The last submitted patch, field-extra-1561352-2.patch, failed testing.
#6
commited 8ee534e
Suppose this could be backported to 8x. probably to "advanced module"
#7
pushed ea7dae9
still waits for advanced module
#8
The last submitted patch, 1561352-masquerade-field-7.patch, failed testing.