I entered a recipe & viewed it.

I clicked on the "MasterCook4" export link, then clicked "back" to return to the recipe view.

When I clicked on the "Recipes" link in the Navigation block, a series of warnings appeared:

  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).
  • Notice: Trying to get property of non-object in merge_template() (line 104 of /var/www/drupal002/sites/all/modules/recipe/includes/recipe_mastercook4.module).

There are 11 warnings above and 11 ingredients in my recipe.

Something similar happens with both the "Plain Text" and "recipeML" export links as well.

CommentFileSizeAuthor
#1 1561728-export-formats-ing-abbr-1.patch3.22 KBdcam

Comments

dcam’s picture

dcam commented
Assigned: Unassigned » dcam
Status: Active » Needs review
StatusFileSize
new 1561728-export-formats-ing-abbr-1.patch3.22 KB

I was able to replicate the bug. It occurs when trying to export a recipe in any of the three mentioned formats when an ingredient has no quantity unit.

The problem is two-fold. It occurs where the export pages try to determine whether to print out the unit abbreviation or the full unit name. The reported bug is caused when the ingredient variable is checked as a stdClass object, when it's actually an array. There's another problem though. This code is expecting the abbreviation to already be set, as it is in theme_recipe_ingredients() in recipe.module.

The problem code:

    // Display units or abbreviation.
    // Print the abbreviation if recipe_unit_display says too or the abbreviation is blank (ie = Unit, which we don't print).
    if ( variable_get('recipe_unit_display', 0) == 0 || $i->abbreviation == ' ') {
      $i['str_unit'] = $units[$i['unit_key']]['abbreviation'];
    }

Proposed solution:

    // Display units or abbreviation.
    if (!isset($i['abbreviation']) && isset($units[$i['unit_key']])) {
      $i['abbreviation'] = $units[$i['unit_key']]['abbreviation'];
    }
    if (empty($i['abbreviation'])) {
      $i['abbreviation'] = ' ';
    }
    // Print the abbreviation if recipe_unit_display says too or the abbreviation is blank (ie = Unit, which we don't print).
    if (variable_get('recipe_unit_display', 0) == 0 || $i['abbreviation'] == ' ') {
      $i['str_unit'] = $i['abbreviation'];
    }

Patch is attached.

jvandervort’s picture

jvandervort commented

Side question, how are you getting a recipe without a quantity unit? Bulk import? The single recipe edit screen won't allow a blank unit.

jvandervort’s picture

jvandervort commented
Status: Needs review » Fixed

Thanks for the debugging help, committed fix to dev.

dcam’s picture

dcam commented

I left the units as the default blank option. It gets saved as an empty string in the database.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.