Hi,
I just found, in the themes setting page ({host}/admin/appearance) the sasson SUBTHEME appears. I think, it is not a good practice because this subtheme can be enabled, but this subtheme is just a "template" for creating a real sasson subtheme.

My solution is: adding a hidden = TRUE line to the SUBTHEME/SUBTHEME.info, then after a remove (comment out) it when copying it to the final subtheme directory.

I added this key into the .info file and added a line to the sns drush command to remove this hidden key from the newly created subtheme.

The key hidden is (maybe) an undocumented .info key. The system_themes_page() menu callback uses it.

I attached my patch.

CommentFileSizeAuthor
sasson_subtheme_hidden_feature.patch1.48 KBdenes.szabo

Comments

denes.szabo’s picture

denes.szabo commented
Status: Active » Needs review

Just set the status.

tsi’s picture

tsi commented
Status: Needs review » Fixed

Well, I agree it is a bad practice to have the starter-kit appear on the themes list, but this line may be a little dangerous, because if someone will miss it, they may have a very hard time finding why their sub-theme isn't appearing on the themes page (and no, documenting it doesn't mean people will know about it :) ).
What I did do, is write a better description with a small warning and a link to the docs.
While I was there, I've also improved the drush script so now you can also enable the new theme and set it as the default theme with a single command -
drush sns "My theme" -y
Thanks !

denes.szabo’s picture

denes.szabo commented

Same feature used by the Omega theme, the starterkit subthemes are hidden. They added a big warning into the theme.info for do not forget enable your newly created submodule. I do not see there dangerous situation, actually :D

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit e727dc8 on 7.x-2.x, 7.x-3.x, PHPSass, 7.x-3.x-Assetic, 7.x-3.x-susy by tsi: 
    Issue #1561774 by Denes.Szabo: Add better subtheme handling.