thekevinday pointed out that some redundant code could be eliminated with a workbench_access_active_options() function and that function would be used in Rules support. #1285110-22: Add support for Rules, Actions, and Triggers

I'm starting this issue to add that function prior to adding Rules support.

CommentFileSizeAuthor
#13 1561822-workbench-access-active-options-follow.patch3.92 KBagentrickard
#12 1561822-workbench-access-active-options-follow.patch3.77 KBagentrickard
#11 1561822-workbench-access-active-options-follow.patch506 bytesagentrickard
#9 1561822-follow.patch606 bytesagentrickard
#7 1561822-workbench-access-active-options.patch3.53 KBagentrickard
#5 workbench_access_active_options-1561822-2.patch3.57 KBthekevinday
#1 workbench_access_active_options-1561822-1.patch3.53 KBstevector

Comments

stevector’s picture

stevector
he/him
commented
StatusFileSize
new workbench_access_active_options-1561822-1.patch3.53 KB
thekevinday’s picture

thekevinday commented

Should this also be static cached after the function call, or is that overkill?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review

Probably couldn't hurt. the tree and other vars should already be cached.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Priority: Normal » Major

Bumping, as this blocks other issues.

thekevinday’s picture

thekevinday commented
StatusFileSize
new workbench_access_active_options-1561822-2.patch3.57 KB

I've not had any problems with it.
It seems the latest dev has had quite a large number of changes so I am rebuilding the patch.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Thanks.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 1561822-workbench-access-active-options.patch3.53 KB

Re-roll.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed

Committed.

   bf8ee86..c5ad3d7  7.x-1.x -> 7.x-1.x
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
StatusFileSize
new 1561822-follow.patch606 bytes

Minor follow-up.

   c5ad3d7..1127c75  7.x-1.x -> 7.x-1.x
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Category: task » bug
Status: Fixed » Active

Bah. This patch causes a fatal regression. See #1869088: Restrict sections by access option for new content

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Needs review
StatusFileSize
new 1561822-workbench-access-active-options-follow.patch506 bytes

Fix for the regression.

Needs a test.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Priority: Major » Critical
StatusFileSize
new 1561822-workbench-access-active-options-follow.patch3.77 KB

And a patch with a baseline test.

Please review.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Fixed
StatusFileSize
new 1561822-workbench-access-active-options-follow.patch3.92 KB

Since no one ever tests anything.....

Committed the attached version.

   d98c63a..3487bb6  7.x-1.x -> 7.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.