WFCC

welcome,

You got a wrong named branch '6.x' (see release naming conventions). Please remove it.

git push origin :6.x
git branch -d 6.x

Your project page looks a little short, please have a look at the tips for a great project page.

Also your code is not very well documented. Please document all your functiona, also more inline comments would be nice (it's always good if other developers are able to understand the code without actually reading the code).
Have a look at the coding and documentation standarts.

while waiting for an in-depht review of your module you can start out fixing some coding style issues detected by automated tools:
http://ventral.org/pareview/httpgitdrupalorgsandboxhipfox1562236git

We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.

regards

Hi,

This module seems to me useful, but there is an error message that is shown randomly for a few seconds when I entered a not existing component then I click "Component clone", then the correcte error message appears.

Hello,

The error is generated for me in firefox browser.
I successfully reproduced the error when I click in the button "Component clone" before returning data JSON format (Loding data)
Suggestion: think to disable the button until the data are returned.

Replace "exixt" by "exist" in the wfcc.module file lign 117.

Hello,

The problem is not in drupal_json() callback. You can reproduce it easily if you run the xdebug and you make a breakpoint in the beginning of wfcc_autocomplete_load() function than you enter a caracter. wfcc_autocomplete_load() function is called at this case and the xdebug is launched.
If you click on the button (when the xdebug is running and positioned on the beginning of the wfcc_autocomplete_load() function) the error message appears.

I suggest to disable the button while loading data (You can use a javascript code to disable the button)
This code solves the problem, but it's better to find another solution better than the one proposed:

1- Create a file .js and insert this code:

$(document).ready(function() {
  $('#edit-wfcc-history').keypress(function() {
        $("#edit-wfcc-add").attr("disabled", "disabled");
        setTimeout($("#edit-wfcc-add").removeAttr("disabled", "disabled"), 3000);
});
})

2- Include this file at the beginning of wfcc_form_alter () function

drupal_add_js(drupal_get_path('module', 'wfcc') . '/your_file.js');

Hipfox, I'm more than happy for you to help with Webform Share. It is not a duplicate in relation to workflow / code but this would benefit greatly for this functionality (or vice versa).

Currently it handles Importing / Exporting / Resetting webforms in relation to an exported PHP code segment. The main reason I wrote it was to automatically populate a form based on a saved export in the content type settings.

i.e. Create node (webform) of type Job Application and hit save and bang the entire form is set up

On closer inspection of the code, they are doing totally different things. However, if you want to try and fit this into webform share, I'm happy to review / help where possible.

I would recommend patches so that I can mentor things along. However, is Drupal 7 a better starting point?

Some coding standards validations:

1. wfcc.module - line 60 - now '#weight'=> -100 should be '#weight' => -100
2. readme.txt - line 4 - the line must be no longer than 80 symbols

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

FYI on the old thread http://drupal.org/node/298268