Publishing a previously unpublished node with new revision moderation checked does not get published

dwatson - July 2, 2007 - 21:30
Project:Revision Moderation
Version:6.x-1.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

When a node that was created but not published right away is edited and has the published checkbox checked, it goes into revision. Makes sense, however, when you then say to publish that revision, the node itself is still set to unpublished.

Ex:
Create a page with "create new revision" and "New revisions in moderation" checked, but "published" and "promote to frontpage" unchecked.

Re-edit the page, check the "published" checkbox and submit, this is put into moderation.

Go to the pending revision, click on publish, it says the changes have been saved, but the node itself is still not published.

Happens in a few more ways:

Re-edit the page, check published, uncheck create new revision, leave new revisions in moderation checked and submit, node is still not published, curiously it says it was added into moderation queue, but no new revision was created and it does not appear in the pending revisions block/page.

Related:

Re-edit the page, check published, uncheck create new revision and uncheck new revisions in moderation, the node is then published just as if the pending revisions module didn't exist, but, when you edit the node again, new revisions in moderation is unchecked which means from that point forward unless it is specifically checked again for that node, it stays unchecked, shouldn't this stay checked?

#1

moonray - January 29, 2008 - 18:27

Same issue.

#2

toemaz - February 3, 2008 - 14:08

This problem has been raised many time before in various other issues. There are 3 solutions to solve this problem:
1. Enhance the revision moderation module with a function to publish the node when a new revision is created. You may want to use a setting so the admin can choose to en/disable this behaviour.
2. Make a contrib module
3. Use the actions module to

Feel free to start coding and let it review by the many other users who requested this.

Regarding the 'Related' question: the same answer. It all depends what you really want.

#3

DanielTheViking - February 24, 2008 - 13:14

Subscribing.

#4

add1sun - December 21, 2008 - 18:19
Version:5.x-1.0» 6.x-1.x-dev

Hm, yeah the node_revisions table (where RM is really doing its work) does not store the published status of a node so, as toemaz points out, this would require a change to RM module to store this info somehow and then act on it. It is a little confusing though if you don't know that and I'm not sure how to best explain that to the user.

#5

bmagistro - December 28, 2008 - 01:21

I think this issue needs to be addressed in one way or another. I wonder why just adding a set published to true option on revision approval wouldn't work. In the mean time I am going to use the changes I mentioned in the other issue (http://drupal.org/node/310660)

#6

add1sun - December 28, 2008 - 02:37

Well, again, since RM doesn't know the published flag was set on the revision how should it know to do that when approving the revision? That is an on/off flag in the node table and not tracked in the node_revisions table. Approving a revision doesn't necessarily mean you want the node published.

#7

bmagistro - January 8, 2009 - 04:42

Just wondering, but why would you be approving a revision if it is not going to be published? That seems kind of pointless to me. Just add a second button to say approve and publish, its only a slightly modified sql statement anyways??

#8

gondwanan - February 1, 2009 - 02:59

I get the same thing.

#9

Makea - March 4, 2009 - 20:48

If you are working on draft versions of a document, approving revisions while still unpublished is integral to that workflow.

The current workaround of unchecking the 'create new revsion' and 'revision moderation' is confusing for many users.

 
 

Drupal is a registered trademark of Dries Buytaert.