Modules/Permissions do not collapse when Overlay is enabled

It's a problem with URL fragment. Here is a simple patch.

This was introduced in #870388: Keep module permissions open when there is a hash in the URL

There's trailing white-space in this patch.

I'm not able to reproduce this issue without Overlay.

I can only reproduce it with Overlay enabled. The behavior does not execute, because the passed in settings contain a wrong false value, while it should be true.

The patch in #2 does not resolve the issue for me.

That said, I've little to no interest in Overlay module and its inane implementation, so someone else needs to figure this out.

I don't even have Overlay module enabled and it wasn't working.

For me this started to happen when I updated to RC2 and it still remains in RC3.

@sun: You say in #3 its due to #870388: Keep module permissions open when there is a hash in the URL, however a fix for that issue was committed in march and that was way before RC2 was out. I was running devs until then I IIRC collapse worked fine. Plus, since the problem still is here, maybe its something else.

Apparently it's not just overlay. I have at least one site running admin_menu 7.x-3.0-rc1 with overlay disabled, and collapse not working on either modules or permissions pages.

Collapse *is* working on other sites using 7.x-3.0-rc1 albeit with fewer other modules.

As a test, I enabled overlay on a 7.9 site also with 7.x-3.0-rc1 and collapse still worked on both modules and permissions pages.

HTH.

@forestmars: "HTH"? You're providing debug info based on functionality that's 2 releases behind. No, that doesn't help at all. Please update at least to rc3 first.

@sun, here we are dealing with 2 bugs.

1. Bug described by @modctek is about working with Overlay module.
2. Bug described by me is about permissions page.

Here is the explanation.

First about bug#2 (as it's more simple). The problem is in line 91 of admin_menu.js module, and in three browsers I've checked (Firefox, Chrome, Safari) it shows the same error: Syntax error, unrecognized expression: #. Simply because expression :has(#) is not acceptable. So in case we don't have module selected, we need to skip this action.

Second is about bug#1, with Overlay. Overlay loads itself in iframe, so settings and JS files can't be attached via hook_page_build(). Instead hook_overlay_child_initialize() has to be used, attaching both settings and admin_menu.js (admin_menu.admin.js) only is attached now.

I'm attaching my patch for both issues.

@a.mikheychik: Unfortunately, your patch file didn't upload correctly. Can you attach it again?

Yes, sure.

To be a little picky...

+++ b/admin_menu.module
@@ -241,6 +241,23 @@ function admin_menu_page_build(&$page) {
+  ¶

Contains unnecessary whitespace.

fwiw, I can confirm the fix on my local; modules fieldsets are collapsing spectacularly.

How about this?

That patch does collapse fieldsets fine but introduces a case of the dreaded double-bar. See attached.

FWIW, I've committed the admin_menu.js fix. Thanks for the improved version, @a.mikheychik.

Attached patch should work, but doesn't. I have no effin' idea how this total hack of Overlay was able to end up in core.

Hello,

I have 2 sites running admin_menu 7.x-3.0-rc3 with this issue. I have put in the fixes for admin_menu.js and admin_menu.module per the patches above. I have cleared the cache and I still get the same results when in overlay (Modules/Permissions are not collapsed). Are these patches specifically for rc2?

@ghostbuck Notice that the comment in #16 says this should work but doesn't. ; )

@ghostbuck did you try to use patch #11?

The patch in #11 worked for me after clearing all Drupal caches.

Same issue here, none of the patches work- administrator menu acts like toolbar (no child expansion) for all intents and purposes on any pages with overlay, and homepage. Disabling overlay makes the administrator menu actually fold out on more pages, but not all.

FWIW, I'm using 7.x-3.0-rc3 (dated 2012-05-17) and have observed:

1) Collapsing only works for me with the admin overlay disabled.

2) The "Modules" menu doesn't have a List submenu at all. There's only "Install new", "Update", and "Uninstall". I don't see the removal of the submenu mentioned anywhere in the changelog, so I'm guessing it's a bug. (Browser cache has been cleared, Drupal caches have all been cleared.)

Drupal 7.15 + 7.x-3.0-rc3 on a prod site here.
Overlay module disabled from the very beginning (minimal profile).
Module groups collapse OK, permissions do not.

i had same as #24 - just updated to latest -dev of admin_menu and it seems to be fixed - perhaps Sun's commit in #16 was the fix? should this not be marked as fixed then?

Hi,

Just wanted to add my input ...

On a new website (standard profile) with overlay module disabled, and admin_menu 7.x-3.0-rc3 ...

Permission groups do not collapse.

However, after manually patching this patch:

http://drupalcode.org/project/admin_menu.git/commitdiff/df2b86bd8b800935...

then permission groups collapse ie. it works.

Related issue: #1894380: "uncaught exception: Syntax error, unrecognized expression: #" at admin/people/permissions
Correct me if I'm wrong but this seems fixed in dev and only affects rc3.
So I guess this issue should be closed and a new release out, please.

Turning this into major because it prevents other JS to run.
+ Marking as fixed.

I am still seeing this behavior on a clean install of D7.22 with module version 7.x-3.0-rc4. I also tried 7.x-3.x-dev and had the same issue. It is only in the overlay that the sections are not collapsed. if I look at /admin/modules on the site everything works as expected.

The following patch should do the trick (based on #16).

Another decision must be made, if the tweak_tabs should move to the new file to group them together or if no new file will be created at all.

HTH

MyXelf

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)

Hello!

Ended up running into this issue again actually as we're doing a pass-through updating our modules! Updating to 7.x-3.0-rc6 still has this bug. Per your request above, I also tried 7.x-3.x-dev, and same issue still!

I'm able to replicate the "Permissions collapse issue when Overlay is enabled" bug on both those branches (Screenshot attached).

I'm able to still apply patch #32 against 7.x-3.0-rc6 though, so that's good!

Appreciate this module getting another recent release and the issue threads being cleaned up! :)