Closed (fixed)
Project:
Variable
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 May 2012 at 14:10 UTC
Updated:
4 Jan 2014 at 02:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bforchhammer commentedHere is the patch.
Remaining ToDo's / Open Questions:
system_theme_settingsform: i18n_variable provides special treatment for theme settings -- I am not sure why or whether that needs to be generalized, and therefore haven't added it yet...variable_realm_admin_variable_realm_info_alter()). There are also new hooks which should be added to API docs.hook_variable_realm_switch()into variable_realm, to allow other modules to act on realm switching. It is currently part of the realm admin module and only called when the realm-switcher block is used.hook_variable_realm_info_alter(); I am not sure how to properly translate strings in the info hook, because the results do not seem to be cached per language. (Separate issue?)Follow up tasks for the i18n_variable module, if this patch gets added to the variable module:
variable_realm_admin.variable.inc)i18n_variable_form_alter()andi18n_variable_module_implements_alter()variable_realm_admin_realm_settings()foradmin/config/regional/i18n/variableComment #2
bforchhammer commentedAs per my previous comment, there are still a few bugs and remaining todos... However before I put more work into this I would love to get some feedback and possibly a code review :-)
The main goal for this patch from my perspective, is to simply replicate the functionality provided by the i18n_varibale module on a general level; without adding any new features.
Comment #3
jose reyero commentedThis looks like a great start. Committed to variable module (added a dependency on variable_admin).
@bfordchammer,
You've been added to the commit list of variable module to maintain this new module.
Still I'd like to do some changes to this module, since I think some parts of it should be on variable realm. Let's keep the discussion on the variable_conf module to be more focused. #1559970: Battle plan / Progress
Comment #4
bforchhammer commentedWonderful, thank you very much.
Comment #5.0
(not verified) commentedMinor