Thanks for this module - but my users are most confused about the check box
Show Teamtable in og_mission?

The read me says that the options is

3) select 'show teamtable on group home page' to present the table directly at bottom of your group node or ...

which seems much clearer - but the module - line 231

		$form['showtable'] = array('#type' => 'checkbox', '#default_value' => $val, '#title' => t('Show Teamtable in og_mission').'?');

Definitely says og_mission - is this a mistake (and if not could it be changed anyway please!!)...

I have a couple of other presentation bits - is it possible you could consider them too?

Could line 34

		  if (og_is_group_type($node->type)) {
				$items[] = array('path' => 'node/'. arg(1). '/members', 'title' => t('configure team table view'), 'callback' => 'og_teampage_admin_members', 'callback arguments' => array(arg(1)), 'access' => node_access('update', array('nid' => $node->nid, 'status' => 1)), 'type' => MENU_LOCAL_TASK, 'weight' => 7);
			  };

also have more 'Drupal style' capitalisation? - and maybe be shortened to just be 'Team Table View' or 'Configure Team Table' as it's a bit long?

When on the configure team table view - the heading says
Administer memberships of - should that be 'Administer memberships of [groupname]'?

Could line 328
Saved your changes to group 2192. say instead 'Saved your changes to group [groupname]?'

Comments

MartinSfromB’s picture

First .. sorry for my bad english and this is the reason for the confusion of your users!

~~~~~~~~
og_mission is shorter the 'the bottom of...' but I think noone knows what og_mission is and so I will rename the checkbox to the string how described in the readme.
~~~~~~~~
'Team Tabel View' says that you can view something there but that's not right because it's the tab to configure so I think your suggestion 'Configure Team Table' is the better way ... I'll do it.
~~~~~~~~
The last 2 hints are also known but there is a new database query nessesary for one word and that's the reason to avoid it but I know this bad solution an I'll try to find a solution.

Thanks for your suggestions!

MartinSfromB’s picture

Assigned: Unassigned » MartinSfromB
Status: Active » Fixed

All fixed with commit #72435!

csc4’s picture

Thank you and thank you for the speedy fixes - and I think your English is very good indeed.

Anonymous’s picture

Status: Fixed » Closed (fixed)