Somehow, when verify runs via this hosting_site_git module via drush, the verify fails on the files in the site files dir. It does not fail when you run verify standalone. I think the code:

// Re-verify the site, this corrects the file permission when necessary
$options = array();
$target = d()->uri;
provision_backend_invoke($target, 'provision-verify', array(), $options);

is the issue. I get a bunch of rsync errors from the git pull's verify. Again, the regular verify task is fine. And these rsync errors have nothing to do with the git code, only files in the files dir.

Thanks!

Comments

helmo’s picture

helmo commented

That code code is indeed calling verify.

It might be helpful to see the exact rsync errors...
Which direction gave the errors, master->slave or slave->master?

I think there are situations where verify ignores the files directory.... maybe we need an extra flag here.
I'll have to look into that.

Gerben Spil’s picture

Gerben Spil commented

Perhaps the way verify is called here is not correct. Is d()->uri the target? Should that not be the drush alias? Just a thought, haven't had the time to look into it and probably not for the next week.

Daeluin’s picture

Daeluin commented

Here are the rsync errors cschaub mentioned:

Could not rsync from '/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com' to 'aegir@example.example.com:/'

/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com could not be synced to remote server example.example.com. Changes might not be available until this has been done. (error: rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/Tree_by_io3.jpg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/jasonedens.jpg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/timeline_1.png": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/ctools/css/0e69963ffb2eec1001cba4542ff3ff5b_2.css": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/ctools/css/24cddb93f74cc25f8f6f18aba2a9333c_7.css": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/field/image/fallensoldier.jpeg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/large/public/Tree_by_io3.jpg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/large/public/jasonedens.jpg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/large/public/field/image/fallensoldier.jpeg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/medium/public/field/image/fallensoldier.jpeg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/square_thumbnail/public/Tree_by_io3.jpg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/square_thumbnail/public/jasonedens.jpg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/square_thumbnail/public/timeline_1.png": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/square_thumbnail/public/field/image/fallensoldier.jpeg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/styles/thumbnail/public/field/image/fallensoldier.jpeg": Operation not permitted (1) rsync: failed to set permissions on "/var/aegir/platforms/prod/one-drupal-7.10-1.3/sites/www.example.com/files/webform/resumes/DW pest control.txt": Operation not permitted (1) rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1060) [sender=3.0.7])

helmo’s picture

helmo commented
Title: Verify should hot run on files dir ? » Verify should not run on files dir ?

I still don't really understand the difference between the standalone verify and the one this module is triggering.

Could this be related: #1083366: Make the spokes authoritative for files/ and private/ directories

helmo’s picture

helmo commented
Issue summary: View changes
Status: Active » Closed (won't fix)

Any future development will most likely happen in the hosting_git queue as per #2201133: [meta] Consolidate Git modules

Please move this or add a new issue there if we still have an issue.