Currently when a user uses their one-time login link there is a watchdog message associated with uid 0 but with text that lets us know which uid/name used the link. This is fun for visual review but pretty annoying if you're, say, trying to audit which users are logging in with the one-time link vs. the normal form.

This teeny tiny patch moves the watchdog call a few lines to make it way more useful.

CommentFileSizeAuthor
#11 1564996-11-one-time-login-watchdog.patch1.32 KBdcam
#7 1564996_one_time_watchdog_more_info.patch1.37 KBgreggles
#1 1564996_one_time_watchdog_more_info-D6.patch1.32 KBgreggles
#1 1564996_one_time_watchdog_more_info-D7.patch1.37 KBgreggles
#1 1564996_one_time_watchdog_more_info-D8.patch1.39 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 1564996_one_time_watchdog_more_info-D8.patch1.39 KB
new 1564996_one_time_watchdog_more_info-D7.patch1.37 KB
new 1564996_one_time_watchdog_more_info-D6.patch1.32 KB

And patches.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review

ahem.

Status: Needs review » Needs work

The last submitted patch, 1564996_one_time_watchdog_more_info-D6.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs work » Needs review

The file that matters passes tests.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Makes sense and does not even break string freeze.

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs backport to D6, +Needs backport to D7

Makes sense. Committed/pushed to 8.x.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 1564996_one_time_watchdog_more_info.patch1.37 KB

Same patch with a new name, hoping the d7 testbot will like this more.

dcam’s picture

dcam commented

#7: 1564996_one_time_watchdog_more_info.patch queued for re-testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Reviewed & tested by the community

Same RTBC as previous patch.

David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 6.x-dev
Category: feature » task
Status: Reviewed & tested by the community » Patch (to be ported)

Makes sense - seems like more of a bug fix than a feature request actually. Let's split the difference and call it a task :)

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/bbf0134

This is marked as "needs backport to D6" so I'll move it back there, in case someone wants to work on it. I don't think non-security patches have been committed to Drupal 6 for a long time, though.

dcam’s picture

dcam commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1564996-11-one-time-login-watchdog.patch1.32 KB

Backported #7 to D6.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

FWIW, I do consider this to be a security improvement.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Assigned: greggles » Unassigned
Status: Needs review » Reviewed & tested by the community

Same RTBC as previous.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 1564996-11-one-time-login-watchdog.patch, failed testing.

dcam’s picture

dcam commented
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community

That failure is weird. D6 doesn't even have tests.

Status: Reviewed & tested by the community » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.