The span for print-link is inserted into content types which print version is disabled [#1565430]

from print.module (lines 408-419)

if ($view_mode == 'full') {
      // Insert content corner links
      $node->content['print_links'] = array(
        '#prefix' => '<span class="print-link">',
        '#markup' => '',
        '#suffix' => '</span>',
        '#weight' => -101,
      );
      if (!empty($print_html_link_pos['corner'])) {
        $node->content['print_links']['#markup'] .= print_insert_link(NULL, $node);
      }
  }

Comments

Comment #1

jcnventura

English

commented 7 May 2012 at 13:49

Status:

Active

» Closed (works as designed)

Hi,

Yes, this is a known "feature" which got fixed in #835814: Markup is in #value, should be in #prefix/#suffix for Drupal 6, but Drupal 7 brought it back again.. It originally started as #451408: Empty span element.

I've fixed it once and for all, in the new 7.x-2.x branch, but that one isn't ready for deployment yet. If you're not using the "content corner" option, I'd recommend removing it in CSS for now.

Comment #2

ramsegal commented 7 May 2012 at 14:10

Thanks for your reply!

So i guess i can safely merge only this specific fix, and when time comes the new branch will address this issue..
Right?

Thanks,

Ram

Comment #3

jcnventura

English

commented 7 May 2012 at 15:09

No, the reason why I can't fix it at all in 7.x-1.x is that the module needed a refactoring in order to do that.. All the link stuff is now handled by a single module, so there's a single function that decides whether there's anything in the corner. In the 6.x-1.x and 7.x-1.x branches, there's 3 functions (html, mail and pdf) each one deciding to add something to it.

And please don't use 7.x-2.x yet... It's a work in progress..

Comment #4

ramsegal commented 7 May 2012 at 15:12

Thanks, so i'll leave it as is for now.
When do u estimate the 7.x-2.0 branch will be out?

Comment #5

jcnventura

English

commented 7 May 2012 at 16:18

Soon(ish).. I can't commit to a specific date, as this is all in my spare time.

I'll do a 7.x-2.0-beta1 first to get some user feedback.. The modules have all been gutted and optimized. I also want to add at least one new PDF library and EPUB export, but those can wait for beta2.