Great Job, this is really the right way to do it (for d7)... Do you have permission to promote project or do you need a project review?

CommentFileSizeAuthor
#5 linkimage-1565478-5.patch1.95 KBericclaeren
#4 linkimage-1565478-4.patch1.57 KBericclaeren

Comments

droath’s picture

droath commented

Thank you... I don't have permission to promote this project, I would have to go through a project review first. I rather just join forces with jamesbenison's sandbox project: https://drupal.org/sandbox/jamesbenison/1275344

squarecandy’s picture

squarecandy commented

Very nice... works very well for me so far.
The problem with the approach of http://drupal.org/project/linkimagefield is that since it's a new field type you can't add links to existing image fields.
love this widget approach and think it deserves a separate module!

ericclaeren’s picture

ericclaeren commented

This is a great module! Real simple and helpful. You should definitely run this through a project review and make it a real Drupal project.

Found 2 small improvements in your code:

  • In linkimage_field_formatter_settings_summary has a non translatable string ('Linked to: Image URL').
  • And in your install hook there's a missing description ('description' => 'TODO: please describe this table!',)

Great job and please publish it :)

ericclaeren’s picture

ericclaeren commented
Category: bug » support
Status: Active » Needs review
StatusFileSize
new linkimage-1565478-4.patch1.57 KB

Hi droath,

I wrote a small patch with the 2 minor improvements in my comment above and I have separated the field formatter. By altering the default image formatter to linkimage all fields change, even when they don't have the link image widget. This resulted in many overridden features because the image field was re-used a lot.

By choosing the formatter you give the user a bit more choice and this doesn't mess up features in an existing website and keep things separated.

Maybe you want to consider this patch.

Thanks.

ericclaeren’s picture

ericclaeren commented
StatusFileSize
new linkimage-1565478-5.patch1.95 KB

Sorry, saw another case, where you have multiple images but not all have a link and made a new patch with an extra check if url has a value or empty.

ericclaeren’s picture

ericclaeren commented

Damn, just ran into the problem, manualcrop isn't supporting custom widgets/formatters. mmmm

droath’s picture

droath commented

@dreamlabs

I appreciate your feedback and patch, but I currently dropped development support for this sandbox project. The development that was started here will continue in the Link Widget project.

If you wouldn't mind downloading and installing that module instead, it could fix some of the issues you're experiencing.

Patches and or feedback are welcomed for the Link Widget module!

Thanks,
Droath