I think the timestamp update applied in #1034672: Reset the file's timestamp to the current time on file.save might be useless. As far as I can tell, the proper fix was applied to another module. Also there is no file_save call in the _file_resource_create method so the changed timestamp is never saved to the database.

CommentFileSizeAuthor
#1 1565508_2.patch1.03 KBwedge
remove_file_timestamp.patch615 byteswedge

Comments

wedge’s picture

Title: Useless timestamp update in file_resource_create » Useless timestamp/filemime updates in file_resource_create
StatusFileSize
new1.03 KB

I think we can skip setting the filemime as well. It seems like that is handled by file_save_data. Updated patch attached.

marcingy’s picture

Status: Needs review » Reviewed & tested by the community

Yup I agree we call file_save_data which sets file_get_mimetype and then file_save sets timestamp.

kylebrowning’s picture

Status: Reviewed & tested by the community » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.