This module breaks URLs for og_forum.

Without getting into the whole sordid story, suffice to know that performing it's own node_access check before executing node_add (what ognodeadd does) was the only way to get og user roles to work every time.

That said, I am willing to work to ensure that og user roles will work with og forum.

My guess is that there is some hook og_forums is performing during the node_add process that is looking for arg() values that have been altered by my code. Correct? If so, if you could point me to the function in question, perhaps I can work out some sort of patch.

My idea is that if og_forums is looking for:

/node/add/forum/$tid

I could modify my code to say: /ognodeadd?type=forum&tid[]=$tid&gids[]=$gid

And then, create a patch in the specific function that would look for the tid value instead of arg(3), or type = 'forum' instead of arg(2), or arg(1) = 'ognodeadd' instead of 'add'.

If not, then I'm open to any suggestions you may have.

Sorry for the bother but, as I said, this was the only way I was able to get the module to work perfectly every time.

Here's a patch against the latest version of og_user_roles.

The only url that og user roles hijacks is "/node/add", so I would assume that anything else your module is doing outside of node creation would not be affected by og user roles.

I looked at your code here http://drupal.org/node/141103 and see that if there is a group context, you add "gids" to the url. If there is not a group context, og_user_roles doesn't care because it's only for group content.

The attached patch will take this url:

node/add/forum/$tid?gids[]=$gid
or
node/add/forum/$tid

and change it to this:

node/ognodeadd?type=forum&gids[]=$gid&tid=$tid

If this patch will do the trick, then I'll commit it as soon as you let me know.

Thanks.

I would then look for ognodeadd as my arg(1)

Yes.

...are each of the arguments put into a global variable somewhere? Is it in $_GET?

Yes. This should get them:

  $gids = $_GET['gids'];
  $type = $_GET['type'];
  $tid = $_GET['tid'];

So, if arg(1) == 'ognodeadd' && $type == 'forum' , then you do your thing.

Thanks for working with me on this.

Committing changes now.