due to the problems mentioned in #1515468: Flot D7 code cleaning and #1556468: Visualize project issue metrics on project pages, it really seems like the jquery.flot.js file should be included globally by flot module. this would solve all of the weirdness and workarounds dealing with caching graphs, and b/c of the js aggregation, it would be a very minor page load hit.

Comments

hunmonk’s picture

hunmonk commented

is this still a problem, or does the fix at #1515468: Flot D7 code cleaning address the issue here?

attiks’s picture

attiks commented

It should be working, what problems do you have?

hunmonk’s picture

hunmonk commented

@attiks: this is related to a drupal.org deployment issue: #1556468: Visualize project issue metrics on project pages

reading the commit messages associated with #1515468: Flot D7 code cleaning, it appears the issue was only fixed in 7.x, is this correct? if so this would still be necessary in the 6.x version of the module. i plan to commit a temporary workaround to drupalorg module over at #1565970: include jquery.flot.js globally until flot module does it until/unless this is already a fixed issue in the 6.x version of flot.

please let me know asap, we're trying to get #1556468: Visualize project issue metrics on project pages deployed very soon!

attiks’s picture

attiks commented

D7 does not include the js globally, only on output of a graph, your fix in #1565970: include jquery.flot.js globally until flot module does it should work and I'm in favor to do it only for d.o. and not for all flot installations.

beakerboy’s picture

beakerboy
Primary language English
Location Kentucky
commented
Issue summary: View changes
Status: Active » Closed (won't fix)