populist,
When installing from the 7.x-1.0-beta3 profile I noticed that Panopoly Search, if left enabled in the graphical/web installer, will throw an error:
Parse error: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in /var/www/profiles/panopoly/modules/contrib/search_api_solr/service.inc on line 854
The install at this point will not complete normally, for Panopoly.
The same goes for drush, but the error just tells me that it has trouble installing the apps, but still installs the Drupal core.
When I deselect Search the install will work just fine. Of course, not for Drush, due to the nature of the patch, which installs whatever is defaulted, by design. #1491258: Allow Panopoly to Install with Drush (Including Apps support) Assigned to: populist
Possibly, Panopoly Search could be left deselected by default?
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 1565996-panopoly-search-not-default.patch | 578 bytes | populist |
| #8 | panopoly-search.patch | 1010 bytes | omega8cc |
| #4 | panopoly-search-dependencies-4.patch | 497 bytes | mrf |
Comments
Comment #0.0
jeremiahtre.in commentedclarified some points, moved a link.
Comment #0.1
jeremiahtre.in commentedproper nouns
Comment #0.2
jeremiahtre.in commentedadded clarifier
Comment #0.3
jeremiahtre.in commentededit to sentence...
Comment #1
omega8cc commentedI agree, it shouldn't be a part of default install, so we had to fix this for Drush/Aegir with simple command:
sed -i "s/^dependencies.*search_api_solr.*//g" panopoly.infoComment #2
jeremiahtre.in commented@omega8cc
Awesome!
Is this a part of a larger command, or did you just edit the file in place, then run
drush site-install?Example of my thought:
Comment #3
rowbotony commentedYES! Thank you omega8cc!
Comment #4
mrf commentedHere's a patch that removes all the dependencies for the search modules. Double checked that these are all covered again by the Search app itself so I don't think they need to be here as well.
Comment #5
omega8cc commentedIt is a part of a few other changes required to make it compatible with Aegir and our BOA stack:
http://drupalcode.org/project/octopus.git/blob/HEAD:/aegir/scripts/Aegir...
As you can see, we also removed redis module, because we already have it added in every Aegir platform by default and duplicate code caused WSOD, and then we download a copy of all apps, to avoid broken first site install, because without this trick the first install fails due to fatal drush errors, while all apps are in fact correctly downloaded and you can provision more sites without this issue.
[EDIT] This needs further debugging, but for now we are using this workaround to be able to include Panopoly in the next BOA-2.0.3 release.
Comment #6
jeremiahtre.in commented@omega8cc
Interesting! Thanks for your disclosure of your clever ways ;-).
jtreinau
Comment #7
jeremiahtre.in commented@mrf
Awesome! I'm going to give this a shot, locally.
jtreinau
Comment #8
omega8cc commentedHere is a better patch - not that you must skip also
panopoly_searchfeature, as otherwise it will try to enable all those search modules causing fatal error anyway.Comment #9
populist commentedNo reason to throw the baby out with the bathwater :) The issue here is that when Search API has a Solr setup it tries to use that for various things (i.e. #1580770: ApacheSolr error when disabling demo module) and errors when it can't connect to Solr. I suppose that is OK behavior since if you setup Solr you want it to work, but Panopoly Search ships with Solr support.
The resolution I think will work (see attached patch) is to disable the Solr indexes by default and include a NEW Search API DB backend so things still are awesome in Search but if you want solr you have to do more work. This is ready to roll for Beta 4, but holla around this.
Comment #10.0
(not verified) commentedbroken eng/