I just checked out the 4.7 version of the module.
A smileys.patch is included, but there is no mention of it in INSTALL.txt

What do I do with it? Apply it?
Has it been checked in by mistake?

Comments

Gurpartap Singh’s picture

Gurpartap Singh commented
Status: Active » Closed (won't fix)

Steven Wittens had committed it, and seems it's there to indicate the changes from 4.6.x to 4.7.x version.

beginner’s picture

beginner commented
Status: Closed (won't fix) » Active

That's silly. If someone wants to know the changes, they can checkout both versions and make a diff themselves. Not many would want to know that, though.

As it is, the included patch will confuse users. And it did confuse me: I was wondering what I was supposed to do with it. Apply it?
So I wasted some time to check what the patch was about.

This is the first module I see where a patch is actually included, but that doesn't need to get applied.

Gurpartap Singh’s picture

Gurpartap Singh commented
Status: Active » Closed (won't fix)

Sorry but don't want to touch steven's commits, unless it's security related, or a severe bug :)