A newsletter Opt-in is configured as single however a confirmation is still sent to user.

CommentFileSizeAuthor
#3 webformsimplenews-optinout+emailsave-1366926+1566576-7.patch2.44 KBzanix
#2 webformsimplenews-optinout-1566576-2.patch2.16 KBaheredia

Comments

meishme’s picture

meishme commented

Same here. Confirmation emails should not be sent to the user if the newsletter they're subscribing to is configured as "Single" (as opposed to "Double").

aheredia’s picture

aheredia commented
Status: Active » Needs review
StatusFileSize
new webformsimplenews-optinout-1566576-2.patch2.16 KB

The problem is that Opt-in/out method varible isn't stored in a varible called 'simplenews_opt_inout_' . You should use the function 'simplenews_require_double_opt_in' to retrive this value.
I think this patch should solve the problem.

zanix’s picture

zanix
Primary language English
commented
StatusFileSize
new webformsimplenews-optinout+emailsave-1366926+1566576-7.patch2.44 KB

The patch above doesn't account for $value['newsletter_selection'] not being set or having a value.
This case happens when there is not a choice to pick the newsletter they sign up for.

This patch fixes this issue, #1364832: single opt_inout newsletter sends confirmations emails , #871558: compatibility with simplenews 2.x (for the 7.x version), and #1366926: emails are not saved in simplenews database as well.