Problem/Motivation

Module is failing on a few E_NOTICE points, and there's also a warning regarding arguments to array_merge() not being a view, possibly related to #1440476: Argument #2 is not an array in entity_translation_menu_alter(). To reproduce, we just had to save a view with modifications. The view saves correctly, but there are these ugly errors.

Proposed resolution

Proposed solution is to first check that a value is set, before trying to use an unassigned variable or array key.

Remaining tasks

Review the attached patch. Please bear in mind I have no base understanding of the module itself, so the patch makes the errors disappear, but could use review by someone who understands what its consequences might be.

CommentFileSizeAuthor
#3 entity_translation_missing_args_proper.patch1.51 KBchriscohen
entity_translation_missing_args.patch1.88 KBchriscohen

Comments

Status: Needs review » Needs work

The last submitted patch, entity_translation_missing_args.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs work » Postponed

This is probably related to #1341314: Nested call of entity_get_info() due to menu_get_router() in entity_translation_entity_info_alter() .

chriscohen’s picture

chriscohen commented
StatusFileSize
new entity_translation_missing_args_proper.patch1.51 KB

Sorry, accidentally posted some extra unrelated crap in that previous patch. Proper patch here, hopefully.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Postponed » Postponed (maintainer needs more info)

Please try the latest dev (a new snapshot will be out in 4 hours) and check whether the issue is now fixed.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

Cleaning up the queue.
Reopen if needed.