Looks like a bug in the lock system that we even could break it, but I defer to pounard there since he's worked on it most recently. pounard, you want to take a stab at this?

Comments

pounard’s picture

pounard
Primary language French
commented

Ok, I guess I'm the man for this. Any more details?

Crell’s picture

Crell commented

Not at the moment. Assign to yourself and dive in. It will probably become obvious what the issue is when you get into it. (I hope. :-) )

pounard’s picture

pounard
Primary language French
commented
Assigned: Unassigned » pounard
Status: Active » Fixed

Fixed and pushed over the 1567444-LockFunctionalTest new branch.

Crell’s picture

Crell commented
Status: Fixed » Needs review
pounard’s picture

pounard
Primary language French
commented

Unmarked as fixed, awaiting for Crell merge & approval.
EDIT: Cross post.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Did a quick diff on the branch and looks solid and fits at least with the documentation of the DatabaseExceptionWrapper class.

Crell’s picture

Crell commented
Status: Reviewed & tested by the community » Fixed

Merged and pushed. Thanks guys!

pounard’s picture

pounard
Primary language French
commented
Status: Fixed » Needs review

Changed the catch statement to catch DatabaseExceptionWrapper instead of DatabaseException as stated with Crell on IRC. Tests still passing on my box. Commited on the same branch.

aspilicious’s picture

aspilicious commented

Sadly enough this doesn't fix the database transaction test

Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42000]: Syntax error or access violation: 1305 SAVEPOINT savepoint_1 does not exist: RELEASE SAVEPOINT savepoint_1; Array ( ) in Drupal\Core\Database\Connection->query() (line 533 of C:\xampp\htdocs\drupal8\core\lib\Drupal\Core\Database\Connection.php).

pounard’s picture

pounard
Primary language French
commented

Yep, but it does fix lock tests, so that comment is for another issue I guess.

aspilicious’s picture

aspilicious commented

indeed it is

Crell’s picture

Crell commented
Status: Needs review » Fixed

Merged the follow up. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.