A small change I made to function menu_edit_menu_submit() wasn't quite right. It should only append 'menu-' to the name for new custom menus, but right now it appends it to all when added OR edited.

CommentFileSizeAuthor
#5 custom_menu_submit_3.patch3.15 KBpwolanin
#2 custom_menu_submit.patch1.55 KBchx
#1 custom_menu_submit_2.patch2.15 KBpwolanin
custom_menu_submit_1.patch2.19 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
StatusFileSize
new custom_menu_submit_2.patch2.15 KB

minor code changes to avoid repeating the same string concatentation many times with the static string.

chx’s picture

chx commented
StatusFileSize
new custom_menu_submit.patch1.55 KB

I more like this way.

chx’s picture

chx commented

Ignore my patch it's broken, let's go with #1 .

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

need to fix the validation function too.

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new custom_menu_submit_3.patch3.15 KB

with validation function fix too

webernet’s picture

webernet commented
Status: Needs review » Reviewed & tested by the community

Tested, and everything appears to be working properly.

flk’s picture

flk commented

test and seems to be working fine,
rerolled against head.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed (although it applied with a bit of fuzz, it was OK).

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)