see:

function node_multiple_delete_confirm
function node_revision_delete

CommentFileSizeAuthor
#1 dapi_remnants.patch18.17 KBasimmonds

Comments

asimmonds’s picture

Title: incomplete DAPI roll-back in node module » incomplete DAPI roll-back in comment and node modules
Component: node system » base system
Status: Active » Needs review
StatusFileSize
new18.17 KB

Have included in this patch the code from the CVS revision immediately previous to the DAPI commit for:
- comment_multiple_delete_confirm()
- node_multiple_delete_confirm()
- node_revision_delete()

The will bring this code back to before DAPI was introduced.
Tested multiple comment and node deletions, as well as a node revision deletion.

also have included the removal of the DAPI functions:
- _drupal_delete()
- _drupal_delete_execute()
- drupal_redirect()
from common.inc
A grep of the core code shows no usage of these 3 functions, apart from actions.(inc|module) which has a open issue for this and other problems.

AjK’s picture

Status: Needs review » Reviewed & tested by the community

As of now patch still applies, however an offset is required for comment.module hunk #1:
Hunk #1 succeeded at 1284 (offset -12 lines).

Tested all the delete functions this patch touches and they now work fine (which were broken without patch).

gábor hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed!

Anonymous’s picture

Status: Fixed » Closed (fixed)