The Truncate plugin always shows the ellipsis when the checkbox is checked. It doesn't need an ellipsis if the field is too short to be truncated.

CommentFileSizeAuthor
#2 feeds_tamper-ellipsis_when_needed-1567970-2.patch1.24 KBsmokris
#1 feeds_tamper-ellipsis_when_needed-1567970-1.patch1.23 KBjlstrecker

Comments

jlstrecker’s picture

jlstrecker
they/them
Primary language English
Location Athens, Ohio, USA
commented
Status: Active » Needs review
StatusFileSize
new feeds_tamper-ellipsis_when_needed-1567970-1.patch1.23 KB

Patch is attached.

smokris’s picture

smokris
Location Athens, Ohio, USA
commented
StatusFileSize
new feeds_tamper-ellipsis_when_needed-1567970-2.patch1.24 KB

Also, Drupal core has truncate_utf8(), which this plugin could use, instead of duplicating this functionality. Updated patch attached.

twistor’s picture

twistor commented
Status: Needs review » Patch (to be ported)

Nice. We should probably add config settings for the rest of the settings for truncate_utf8() but that's a separate issue.
7.x http://drupalcode.org/project/feeds_tamper.git/commit/ae5843e

algazaras’s picture

algazaras commented

Hi twistor,

I am getting into this problem with Feeds Tamper 7.x-1.0-beta4 . I have seen in the notes that it must be ported. So, did you get it to work? Is it posible to use the 6.x patch?

Thanks a lot

twistor’s picture

twistor commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Component: Code » Plugins
Issue summary: View changes
Status: Patch (to be ported) » Closed (fixed)

This was committed to 6.x a long time ago.