With Domain Access, we are getting page titles "Page Title | LAST DOMAIN WHERE CACHE WAS FLUSHED" and we either need to disable the page title metatag or to ensure that the cache is set to per-domain.
Current workarounds for D7 are not available for DA yet to do cache table caching (domains are not final either for domain specific cache table prefixes settings.php)
So that leaves it at the theme level to do our own override, which seems hacky for such a nicely programmed module.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | metatag-n1568164-3.patch | 582 bytes | damienmckenna |
Comments
Comment #1
couturier commentedThere is some new work going on with setting page titles, and we are also looking at issues with cache flushing for tables. This is not exactly your problem, but it might interest you (see link). Page title functionality has been kind of an afterthought with Meta Tags, since the Page Title module handled all that for so long: http://drupal.org/node/1809652
Comment #2
damienmckennaAlan: I've found the relevant Domain Access issue (#1570228: Separate cache keys per domain), lets brainstorm with Ken.
One way of doing this would be to specifically add a check for the Domain Access module's presence and then insert the domain's name into the cache ID; another alternative would be to add a hook to allow other modules to alter the cache ID, which might be cleaner.. I'll ponder this.
Comment #3
damienmckennaHow would this work?
Comment #4
damienmckennaCommitted.
Comment #5
alan d. commentedFine :)
I'll follow up with DA if I can find some free time...
Comment #6
damienmckennaLast night saw the release of 7.x-1.0-beta1, so I'm closing all these "fixed" issues in the interest of tidying up the issue queue. Thank you all for your help getting us to this point!