Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Attached is a spam.pgsql file that seems to work for me.
Comment | File | Size | Author |
---|---|---|---|
#4 | spam.patch | 521 bytes | Zed Pobre |
spam.pgsql | 1.86 KB | Zed Pobre |
Comments
Comment #1
Zed Pobre CreditAttribution: Zed Pobre commentedThere are additional problems in spam.module itself, it seems. In PostgreSQL, ' and " have different meanings, and you use " (which is used in PostgreSQL for selecting columns) when you generally need to use ' (which is used for specifying a string).
Unfortunately, fixing this is going to be somewhat tedious, since these characters are generally embedded in another string... which used the opposite style of quote to begin and end, and thus must be reversed as well.
Comment #2
(not verified) CreditAttribution: commentedThanks! spam.pgsql is committed and spam.module is updated to use " for strings in db_queries. The change is only committed to the CVS version at the moment -- please test and confirm that everything works as intended.
Comment #3
Zed Pobre CreditAttribution: Zed Pobre commentedGreat progress has been made, but it's not completely fixed yet. I was able to successfully mark a number of comments as not spam, but when I tried changing the status from not spam to spam on one of the comments as a test, I got:
Comment #4
Zed Pobre CreditAttribution: Zed Pobre commentedThe attached patch seems to clear up the last problems.
Thanks for looking into this so quickly.
Comment #5
Jeremy CreditAttribution: Jeremy commentedFixes commited to cvs head and the 4.5 version of the spam module. Thanks! If you run into any further PostgreSQL support issues, please let me know.
Comment #6
(not verified) CreditAttribution: commented