By default, the only options that are passed into the theme_feed_icon() are the URL and title of the feed. However I suggest that we add the view name and current display as additional arguments so that when I can mytheme_feed_icon within template.php people can create a distinction between different pages and blocks. I needed to do this recently to use different RSS icons for different displays.

I've created a quick patch (attached), although this site is SVN based, but it applies for me locally using git apply -v.

Ollie

CommentFileSizeAuthor
#4 1568690-4.patch695 bytesopdavies
views-additional_feed_icon_variables.patch658 bytesopdavies

Comments

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ plugins/views_plugin_style_rss.inc	(working copy)
@@ -30,7 +30,7 @@
+      $this->view->feed_icon .= theme('feed_icon', array('url' => $url, 'title' => $title, 'view' => $this->view->name, 'display' => $this->view->current_display));

In all other theme function calls view stands for the full view object, so this should be the case here as well. From that you can get the current display really easy. What do you think about that, as this allows you more flexibility as well?

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented

Yes, that sounds fine. :)

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Issue summary: View changes

Updated some text

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 1568690-4.patch695 bytes

Here's a better patch. :)

Status: Needs review » Needs work

The last submitted patch, 4: 1568690-4.patch, failed testing.