Closed (fixed)
Project:
OG Aggregator
Version:
5.x-1.0-2
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Jul 2007 at 05:25 UTC
Updated:
17 Mar 2009 at 10:27 UTC
Jump to comment: Most recent file
Comments
Comment #1
rconstantine commentedSorry for not posting a proper patch.
The changes are slight. I changed some titles of the tab links and moved all but one tab to a second row. The 'News feeds' link is now the only tab on the group, and an 'Overview', 'Feeds admin' and 'Add feed' tab are underneath it. The only other changes were to the paths. They are now all under /aggregator. Calls to them in the rest of the code were all adjusted accordingly.
I'm attaching the total module file in case someone wants to roll a proper patch. I'd do it, but the tools I routinely use, while fine for me, have gotten complaints here at Drupal for not producing the exact same diff/patch files.
And anyway, I don't recall whether I have the latest version or not, so you'll have to check that. In any case, making the changes by hand took no more than ten minutes.
Comment #2
rconstantine commentedI should warn you that I made one other change to the above attached file. I changed the menu items (which precede the quoted ones) such that og_aggregator is under the Organic Groups menu in the admin menu.
Another change I made, which was not attached, was in the info file. I set
package = "Organic groups"so that it's grouped with OG in the modules list.Comment #3
Christefano-oldaccount commentedThese are great changes. I'll review this and roll a patch when I get back to the office.
Comment #4
rconstantine commentedI made one mistake. The last menu item (the one for editing existing feeds) should have arg(5) now instead of arg(4).
Comment #5
Christefano-oldaccount commentedHere's a patch. I'll begin reviewing it shortly.
Comment #6
Christefano-oldaccount commentedHmm, the last attachment is zero bytes. Let's try again.
Comment #7
csc4 commentedDid the reviewing happen?? Will it be committed soon?
Comment #8
christefano commentedcsc4, please feel free to review the patch. (I rolled rconstantine's code into a patch so that others could review it, too.) It would be great to hear about your results.
Unfortunately, my time has been pulled in different directions since October and I haven't tested it thoroughly. It's not likely that I'll be able to any time soon.
Comment #9
Taz commentedThis has now been comitted and is a new release.