Hi,
First and formost , thanks for this wonderful module. I had been looking for this for sometime now.

I tried to use this module on my test site and faced some problems with (look at screenshot)
1) uaing the tab.png as a background - The right side of the tab.png was always clipped
2) borders - I could not get rid of the border just under the tab.png image
3) loading.gif - I tried to use the loading.gif image but it did not work. I placed a loading.gif image in the folder and uncommented the code as mentioned, but still wasnt able to get the loading.gif to appear

I had a look at your website to see how tabbed_block worked there. It seems to work exaclt the way It should work. Is there anything different or additional in the code being used there??

Thanks

Manuj

CommentFileSizeAuthor
#4 tabbed_block.css_.patch542 bytesjoetsuihk
tabbed.jpg145.12 KBmanuj_78

Comments

joetsuihk’s picture

joetsuihk commented
Assigned: Unassigned » joetsuihk

first of all, thx for using this module.
about the background image, note that the image is not enabled by default, on the HEAD from drupal.org.
I was wondering if you enable it by changing the CSS file?
if this is the case, i will suggest you to use the CSS file from my site, as further releases will not use the background image by default also.
sorry about the confusion if my site's appearance made you confuse, and comments welcomed if it really need background image, for any reasons.

have a nice day,
Joe Tsui

manuj_78’s picture

manuj_78 commented

I did enable the by changing the css file. I removed the comment from the lines as suggested
BEFORE 

 /*background: url(tab.png) no-repeat;*/

AFTER 

 background: url(tab.png) no-repeat;

I will try the css file from your site and will let you know how it goes.
I think not using the backgrund image by default is a good idea as a lot of people will not want to use it anyway.

Manuj

manuj_78’s picture

manuj_78 commented

I tried the css from your site and manged to get background image to work.

However, I coul not get the loading.gif to work

I placed a loading.gif in the tabbed_block folder

and uncommented the code as mentioned in the css but no luck

BEFORE

/* Uncomment this if you want a little spinner to be shown next to the tab title while an Ajax tab gets loaded
.tabs-loading span {
    padding: 0 0 0 20px;
    background: url(loading.gif) no-repeat 0 50%;
}*/

AFTER

/* Uncomment this if you want a little spinner to be shown next to the tab title while an Ajax tab gets loaded*/
.tabs-loading span {
    padding: 0 0 0 20px;
    background: url(loading.gif) no-repeat 0 50%;
}

Is there something else that needs to be done here??

Manuj

joetsuihk’s picture

joetsuihk commented
Status: Active » Needs review
StatusFileSize
new tabbed_block.css_.patch542 bytes

sorry that the "loading" is drop out since something like v0.6
but i still fix it to 5.x-1.x in case someone will use
please find the patch

also some clean up of the CSS file is made

manuj_78’s picture

manuj_78 commented

the patch seems to work. I have put it on my production site and will let you know if there are any more issues

Thanks for the support

joetsuihk’s picture

joetsuihk commented
Status: Needs review » Closed (fixed)

nth to commit at all.

manuj_78’s picture

manuj_78 commented

I think the patch does need to be commited to the css file as otherwise the loading.gif will not work

joetsuihk’s picture

joetsuihk commented

commited the patch. note that no loading.gif is included in the HEAD.
anyone can provide a GPL image?