services_str_getcsv times out on php 5.2 machines

Thanks, the while() loop never ends. There's a few replacements for str_getcsv in PHP 5.2, maybe that one just doesn't work.

Grabbed the str_getcsv replacement and threw it into PHP, just to make sure it wasn't anything in Drupal:

<?php
$string = "12345";

    $temp = fopen("php://memory", "rw");
    fwrite($temp, $string);
    fseek($temp, 0);
// endless loop
    while (($data = fgetcsv($temp, 0, $delimiter, $enclosure, $escape)) !== false) {
      $ret[] = $data;
    }
    fclose($temp);

print_r($ret);

Got it - in PHP 5.2 the last argument ($escape) doesn't exist, triggering a function warning.

Remove $escape and it seems to work.

Patch for the record.

Now that I think about it, I think this still might be wrong in both versions for PHP 5.2

str_getcsv returns an indexed array of fields (1 row). But, the PHP 5.2 equivalent seems to be returning a nested indexed array of fields (multiple rows)...right?

I think it should be something like this instead.

Patch for 7x

Can we port this to 6.x-3.x too? Fix should be the same.