'Select' field as email subject is malfunctioning?

I am still experiencing this issue. Any suggestions? Anyone? Bueller?

OK, I've tried lifting out the following section:

          if ($type == 'textfield' || $type == 'hidden') {
            if ($component['name'] == $node->email_from_name) {
              $email_from_name = strip_tags($form_values['submitted'][$cid]);
            }
            if ($component['name'] == $node->email_subject) {
              $email_subject_string = strip_tags($form_values['submitted'][$cid]);
            }
          } elseif ($type == 'email' && $component['extra']['carboncopy'] == 'Y' ) {
            $headers['Cc'] = $form_values['submitted'][$cid];
          }

And replaced it with the following (I thought I'd optimise the repeated 'if' statements into a SWITCH statement while I was there):

          switch ($type) {
            case 'textfield':
            case 'hidden':
              if ($component['name'] == $node->email_from_name) {
                $email_from_name = strip_tags($form_values['submitted'][$cid]);
              }
              if ($component['name'] == $node->email_subject) {
                $email_subject_string = strip_tags($form_values['submitted'][$cid]);
              }
            break;
            case 'email':
              if ( $component['extra']['carboncopy'] == 'Y' ) {
                $headers['Cc'] = $form_values['submitted'][$cid];
              }
            break;
            case 'select':
              $formitem = _webform_render_select($component);
              $selectvalue = $formitem['#options'][strip_tags($form_values['submitted'][$cid])];
              
              if ($component['name'] == $node->email_from_name) {
                $email_from_name = $selectvalue;
              }
              if ($component['name'] == $node->email_subject) {
                $email_subject_string = $selectvalue;
              }
            break;
          }

That seems to have sorted it, and even retrieves the displayed value rather than the form-safe value. I've not tested it in every case, though, so I'd welcome input.

I'm going to mark this as 'patch (code needs review)' though I haven't written an actual patch file since, as noted above, I have no patch file writing software. If somebody could do so please feel free :)

That patch doesn't touch the implementation section - it's amending the part where it decides what options are available, but doesn't affect the completely separate function which takes the configured options and applies them to the generated email (function webform_client_form_submit).

Also it appears to be a patch for 4.7 (though obviously any decent code monkey could pick out the changes and apply them to the 5.x code).

A quick check of 5.x-1.6 confirms that it's still using the if ($type == 'textfield' || $type == 'hidden') logic, though it has altered slightly to incorporate the 'email' case. The 'select' case is still not accommodated in the webform_client_form_submit function, only 'email', 'hidden' and 'textfield'.