Hi,

I am not sure whether this is caused by the Talk module. But I am getting this notice only when accessing the talk page, no matter what theme I use:

Notice: Undefined index: title in theme_links() (Zeile 1630 von E:\xampp\htdocs\test\includes\theme.inc).

The functionality is not harmed though it seems.

CommentFileSizeAuthor
#22 talk-fix_index-1569762-18.patch775 bytesbago
#20 talk-fix_index-1569762-18.patch775 bytesbago
#18 talk-fix_index-1569762-18.patch739 bytesbago
#13 talk-fix_index-1569762-13.patch524 bytesThomas_Zahreddin
#8 talk-fix-notice-1569762-8.patch1.17 KBdieuwe

Comments

Sylense’s picture

Sylense commented

I am getting the same error message as well

ey’s picture

ey commented

I am also getting the same notice.

rghoward’s picture

rghoward commented

Same

tricasse’s picture

tricasse commented

This is appearing when the "Add new comment" link is not shown.

ey’s picture

ey commented

Is there any option to set this "Add new comment" link to be shown?

cates111’s picture

cates111 commented

I'm getting this error as well. I wonder is there is a fix in the works?

zauberertz’s picture

zauberertz commented
Status: Active » Needs review

The issue is related to the function "theme_talk_comments".

The link that is build within this function does not include a link title.
Add after this line (line 292):
$links_comments['comment-add']['href'] = "node/$node->nid/talk";
Following line:
$links_comments['comment-add']['title'] = talk_title($node, 'link');

dieuwe’s picture

dieuwe
Location Auckland, NZ
commented
StatusFileSize
new talk-fix-notice-1569762-8.patch1.17 KB

Here is a patch for #7

Status: Needs review » Needs work

The last submitted patch, talk-fix-notice-1569762-8.patch, failed testing.

zauberertz’s picture

zauberertz commented
Status: Needs work » Needs review

#8: talk-fix-notice-1569762-8.patch queued for re-testing.

The Patch itself is not wrong but some thing with the test system.

Status: Needs review » Needs work

The last submitted patch, talk-fix-notice-1569762-8.patch, failed testing.

elBradford’s picture

elBradford commented

Maybe this issue is for the wrong version? Did you make the fix and produce the patch from beta4?

Thomas_Zahreddin’s picture

Thomas_Zahreddin commented
StatusFileSize
new talk-fix_index-1569762-13.patch524 bytes

patch reduced to one actual different line

elBradford’s picture

elBradford commented
Status: Needs work » Needs review

Updated so patch can be tested.

Status: Needs review » Needs work

The last submitted patch, talk-fix_index-1569762-13.patch, failed testing.

elBradford’s picture

elBradford commented

I think the patch needs to be created from the dev branch, not the main branch.

Thomas_Zahreddin’s picture

Thomas_Zahreddin commented

at #16

yes, indeed,

and therefore i rewrote the patch against the dev - Version (from git), and i followed
this howto (like many times before) http://drupal.org/node/1054616 .

Any ideas?

bago’s picture

bago commented
Status: Needs work » Needs review
StatusFileSize
new talk-fix_index-1569762-18.patch739 bytes

I also added a checkl for "comment_forbidden" because in my setup I had strange issues with talk module and anonymous users not allowed to comment.

Status: Needs review » Needs work

The last submitted patch, talk-fix_index-1569762-18.patch, failed testing.

bago’s picture

bago commented
Status: Needs work » Needs review
StatusFileSize
new talk-fix_index-1569762-18.patch775 bytes

Another attempt

Status: Needs review » Needs work

The last submitted patch, talk-fix_index-1569762-18.patch, failed testing.

bago’s picture

bago commented
Version: 7.x-1.0-beta4 » 7.x-1.0
Status: Needs work » Needs review
StatusFileSize
new talk-fix_index-1569762-18.patch775 bytes

OPs.. forgot to update the issue Version to 1.0, so the patch should pass.