Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 May 2012 at 02:05 UTC
Updated:
12 Oct 2012 at 11:34 UTC
The simple_disclaimer module
is a Drupal 7 module which asks authenticated users to acknowledge a disclaimer before accessing content throughout the site.
It differs from existing modules:
Comments
Comment #1
Elvar commentedHi Enjaygee
You should be working on a version oriented branch, and not master.
"The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git."
Automated review.
http://ventral.org/pareview/httpgitdrupalorgsandboxenjaygee1569400git
Read more about the coding standards her http://drupal.org/node/318
I'm setting this to needs work, will do a manual review when following is fixed. :-)
Comment #2
patrickd commentedPlease don't paste the full automated review in here, it makes the issue look clumsy. A link to the report or attachment is absolutely enough. as you can still edit your comment, please shorten it.
thanks for your participation.
Comment #3
patrickd commentedAs installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also create a README.txt that follows the guidelines for in-project documentation.
We do really need more hands in the application queue and highly recommend to get a review bonus so we can come back to your application sooner.
regards
Comment #4
enjaygee commentedThank you very much for the help Elvar. I will make the changes suggested by the automated review and move to an appropriate version-oriented branch.
Comment #5
enjaygee commentedThanks for the help patrickd. I will update the project page appropriately and establish a proper README.txt.
Comment #6
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.